Assorted smallish vanilla fixes from Tianxia #204
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Don't overwrite cooler nicknames with "the Conqueror"
Several combat tactics involving two troop types now have ORs, considering that having >= 30 % of troop type A plus >= 70 % of troop type B is all but impossible.
Reversed light inf and light cav in trigger, seeing as the MTTHs have the light cav in the OR and the light inf outside it.
Not a serious vanilla bug, but maybe important for immersion: Naming someone for a (close) ancestor is not something that's done in Chinese culture, so vanilla not blocking that is kind of weird
Corrected typo in flag; the previous one is never set
There was a rat icon added long after this modifier, and that might be more immersive
Hid two modifiers that'll spoil infidelity if you see them on a spouse/etc.
Missed one!
Zoroastrians would not sully sacred fires with heretics/etc.; fix does not cover event-based executions of e.g. captured DWs, but at least fixes regular executions
"Grandmaster of Myrmidons" and stuff like that is kind of off
Even a barbarian should know that the glory of Rome comes ahead of "My dynasty".
Switched feudal_opinion for vassal_opinion in the Conclave vassal war laws; feels rather more logical that your non-feudal vassals get upset and that feudals in other realms don't care
nick_the_cannibal now checks the trait, not the deprecated modifier
As you don't have to have a pious trait to pick the ambition, not having one should not be reason enough to fail
Eastern religions once again have crusade_name = GREAT_HOLY_WAR even though they can't declare them, seeing as the interface otherwise reads "No BLANK called".
Considering the contexts in which they are earned, "the Avenger", "the Glorious" (restoring the Roman Empire...), and "the Magnificent" are probably not "lame".
The Fellowship of Hel might perhaps not want to risk Odin infiltrating their ranks, so being One-eyed feels like something that perhaps should be a downside rather than an advantage
Yngvar/Igor can no longer pick up "local" traditions that aren't, you know, local
Ordering someone to take the vows now explicitly breaks any betrothal, and consort relationships end right away (as opposed to after the game realizes that the concubine has moved to another court/has become an ascetic).
If you or the target is inaccessible or incapable, it'd be pretty hard to send a gift of this kind...
Sanity check
Courtiers that are incapable or inaccessible shouldn't pick up lovers/friends/stats/nicknames completely randomly
Indestructible artifacts can no longer be picked for destruction by the Rains in Africa, blessed or not.
Consistent spelling of flag and artifact
Presumably this event gets weird in wastelands or water provinces...
Given that these characters end up as lovers, ensuring they're adults seems better than vanilla's 15+...
The "interesting Muslims" that were physicians now are, even if vanilla didn't care to give them the trait
charge_dishonorable was never set, charge_slanderer was...
Proper setup for all five gender laws (vanilla hadn't bothered with Enatic/En-Cog). Simply reuses the stuff already in the file in different ways. Note that the order has Enatic before En-Cog, as that's how the laws are.
Whizzer
approved these changes
Aug 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See individual commits