Add filter option for fetching container logs#30
Add filter option for fetching container logs#30cristian-milea wants to merge 1 commit intockreiling:mainfrom
Conversation
Enhanced the `fetch_container_logs` tool by adding an optional `filter_string` parameter to filter log lines. Updated the tool description to reflect this new functionality.
ckreiling
left a comment
There was a problem hiding this comment.
I'm a little worried that this implies to the caller that they will receive tail log lines when tail is an integer. Though with your current implementation it could return less than tail log lines if there are fewer logs matching filter_string
Can you help me understand a little better the problem you're looking to solve and maybe we can work together on a better solution?
|
Hi! Thank you for your reply 👋 I was thinking of shrinking the output for context size optimization. I had a situation of 500 last logs and wanted about 10 of them based on a keyword. |
|
Understood! Thinking through this I have a couple changes I'd like to be addressed before merging:
|
|
@cristian-milea let me know if you want any further guidance to get this merged! |
Enhanced the
fetch_container_logstool by adding an optionalfilter_stringparameter to filter log lines. Updated the tool description to reflect this new functionality.