Fix extracting license information for pypi packages#518
Merged
mpcen merged 2 commits intoclearlydefined:masterfrom Apr 13, 2023
Merged
Fix extracting license information for pypi packages#518mpcen merged 2 commits intoclearlydefined:masterfrom
mpcen merged 2 commits intoclearlydefined:masterfrom
Conversation
There were issues in parsing LGPL license in spdx-correct. Previously
parsing LGPL was fixed once in "Fixed handling of GNU LGPL licenses in
spdx-correct". The fix depended on the file in /patches directory to
patch spdx-correct. The /patches directory was not included in the
Dockerfile and hence the previous LGPL fix was not effective in the
docker deployment.
There was a recent release of spdx-correct. The LGPL issues that the
patch intended to fix seem resolved. Upgrade spdx-correct to the most
recent version. LGPLv2 and LGPLv2+ are still not correctly identified.
Added patch for the specific cases.
Also update Dockerfile so that the patch will be effective in the container
deployment.
Test cases:
"url": "cd:/pypi/pypi/-/pycountry/22.3.5"
"url": "cd:/pypi/pypi/-/chardet/5.1.0"
"url": "cd:/pypi/pypi/-/PyGObject/3.42.0"
In addition to info.classifier entries in the registry data used to extract license information, there is also info.license in the registry data. This can also provide license information when there is no license information in the classifiers. Tese cases: pypi/pypi/-/dnspython/1.11.0 pypi/pypi/-/pytorch-ignite/0.5.0.dev20220727 pypi/pypi/-/mitmproxy-wireguard/0.1.10
Collaborator
Author
|
@mpcen ready for review |
jeffwilcox
approved these changes
Apr 13, 2023
Contributor
jeffwilcox
left a comment
jeffwilcox
left a comment
There was a problem hiding this comment.
Makes sense. Will share this with Manny to take a look as well.
mpcen
approved these changes
Apr 13, 2023
qtomlinson
pushed a commit
to qtomlinson/crawler
that referenced
this pull request
Feb 6, 2024
Fix extracting license information for pypi packages
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.