Update Node version and dependencies#522
Conversation
d1f0890 to
1b3467c
Compare
|
Looks good to me. Could a sanity test be run to ensure that all component types are harvested ok? Sample payload below to post localhost:5000/requests: |
|
Will do! I ran a few manual tests already but happy to do a few more. Is there any way for me to check the completeness of the results other than an eye test? |
|
Running the crawler without PR and with PR and comparing the harvested raw files at local FILE_STORE_LOCATION can provide some indications. Expect similar harvest file sizes before and after. If you want to compare individual files, expect nothing drastically different except for time stamps and uuids in the temp directory paths. |
|
Do we want to consider update the lockfile version to v3 as well? |
|
Good idea, updated! |
DevDockerfile
Outdated
| # SPDX-License-Identifier: MIT | ||
|
|
||
| FROM node:18 | ||
| FROM node:18-buster |
There was a problem hiding this comment.
bullseye and buster both have openssl 1.1 (https://packages.debian.org/bullseye/mips64el/openssl, https://packages.debian.org/buster/openssl). Compiling Ruby 2.5 is successful with these two images. May be node:18-bullseye is better? What do you think?
|
@qtomlinson How do we go about getting this merged? 🙂 |
|
I don't have rights to merge. |
…pendencies Update Node version and dependencies
Since Node 16 has gone EOL recently and several npm dependencies had critical security vulnerabilities, this PR aims to bring the setup more up-to-date and get us closer to a state where we're running in a current environment with current dependencies.