Skip to content

Update Node version and dependencies#522

Merged
jeffwilcox merged 6 commits intoclearlydefined:masterfrom
lumaxis:update-node-and-dependencies
Oct 31, 2023
Merged

Update Node version and dependencies#522
jeffwilcox merged 6 commits intoclearlydefined:masterfrom
lumaxis:update-node-and-dependencies

Conversation

@lumaxis
Copy link
Copy Markdown
Contributor

@lumaxis lumaxis commented Sep 13, 2023

Since Node 16 has gone EOL recently and several npm dependencies had critical security vulnerabilities, this PR aims to bring the setup more up-to-date and get us closer to a state where we're running in a current environment with current dependencies.

@lumaxis lumaxis force-pushed the update-node-and-dependencies branch from d1f0890 to 1b3467c Compare September 13, 2023 14:58
@lumaxis lumaxis marked this pull request as ready for review September 13, 2023 14:58
@qtomlinson
Copy link
Copy Markdown
Collaborator

Looks good to me. Could a sanity test be run to ensure that all component types are harvested ok? Sample payload below to post localhost:5000/requests:

[
    {
        "type": "component", 
        "url": "cd:/maven/mavencentral/org.apache.httpcomponents/httpcore/4.3"
    },    {
        "type": "component", 
        "url": "cd:/maven/gradleplugin/io.github.lognet/grpc-spring-boot-starter-gradle-plugin/4.6.0"
    },    {
        "type": "component", 
        "url": "cd:/maven/mavengoogle/android.arch.lifecycle/common/1.0.1"
    }, {
        "type": "component", 
        "url": "cd:/crate/cratesio/-/bitflags/1.0.4"
    }, {
        "type": "component", 
        "url": "cd:/npm/npmjs/-/redis/0.1.0"
    }, {
        "type": "component", 
        "url": "cd:/git/github/bitflags/bitflags/518aaf91494e94f41651a40f1b38d6ab522b0235"
    }, {
        "type": "component", 
        "url": "cd:/pypi/pypi/-/backports.ssl_match_hostname/3.7.0.1"
    }, {
        "type": "component", 
        "url": "cd:/gem/rubygems/-/small/0.4"
    }, {
        "type": "component", 
        "url": "cd:/composer/packagist/symfony/polyfill-mbstring/1.11.0"
    }, {
        "type": "component", 
        "url": "cd:/go/golang/rsc.io/quote/v1.3.0"
    }, {
        "type": "component", 
        "url": "cd:/nuget/nuget/-/xunit.core/2.4.1"
    }, {
        "type": "component", 
        "url": "cd:/pod/cocoapods/-/SoftButton/0.1.0"
    }, {
        "type": "component",
        "url": "cd:/deb/debian/-/mini-httpd/1.30-0.2_arm64"
    }	
]

@lumaxis
Copy link
Copy Markdown
Contributor Author

lumaxis commented Sep 20, 2023

Will do! I ran a few manual tests already but happy to do a few more. Is there any way for me to check the completeness of the results other than an eye test?

@qtomlinson
Copy link
Copy Markdown
Collaborator

qtomlinson commented Sep 20, 2023

Running the crawler without PR and with PR and comparing the harvested raw files at local FILE_STORE_LOCATION can provide some indications. Expect similar harvest file sizes before and after. If you want to compare individual files, expect nothing drastically different except for time stamps and uuids in the temp directory paths.

@qtomlinson
Copy link
Copy Markdown
Collaborator

Do we want to consider update the lockfile version to v3 as well?

@lumaxis
Copy link
Copy Markdown
Contributor Author

lumaxis commented Sep 27, 2023

Good idea, updated!

DevDockerfile Outdated
# SPDX-License-Identifier: MIT

FROM node:18
FROM node:18-buster
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bullseye and buster both have openssl 1.1 (https://packages.debian.org/bullseye/mips64el/openssl, https://packages.debian.org/buster/openssl). Compiling Ruby 2.5 is successful with these two images. May be node:18-bullseye is better? What do you think?

@lumaxis
Copy link
Copy Markdown
Contributor Author

lumaxis commented Oct 17, 2023

@qtomlinson How do we go about getting this merged? 🙂

@qtomlinson
Copy link
Copy Markdown
Collaborator

I don't have rights to merge.
@jeffwilcox for review and merge

@jeffwilcox jeffwilcox merged commit a793608 into clearlydefined:master Oct 31, 2023
@lumaxis lumaxis deleted the update-node-and-dependencies branch December 8, 2023 14:01
qtomlinson pushed a commit to qtomlinson/crawler that referenced this pull request Feb 6, 2024
…pendencies

Update Node version and dependencies
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants