Fix fetching latest version for some pod components#588
Merged
qtomlinson merged 2 commits intoclearlydefined:masterfrom Aug 13, 2024
Merged
Fix fetching latest version for some pod components#588qtomlinson merged 2 commits intoclearlydefined:masterfrom
qtomlinson merged 2 commits intoclearlydefined:masterfrom
Conversation
Versions retrieved from the pod registry are sorted lexically. An example can be found at https://trunk.cocoapods.org/api/v1/pods/xcbeautify. Lexically, "0.17.0" < "0.9.1", so the latest version is not always the last item in the versions list. Change to sort by timestamp to retrieve the latest version.
elrayle
approved these changes
Aug 12, 2024
Collaborator
elrayle
left a comment
elrayle
left a comment
There was a problem hiding this comment.
This is great. Very nice bug fix.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Versions retrieved from the pod registry are sorted lexically. An example can be found at https://trunk.cocoapods.org/api/v1/pods/xcbeautify. Lexically, "0.17.0" < "0.9.1", so the latest version is not always the last item in the versions list. Change to sort by timestamp to retrieve the latest version.
Task: #587