Make Crawler queue in Azure separate from Azure results storage#591
Merged
elrayle merged 6 commits intoclearlydefined:masterfrom Aug 12, 2024
Merged
Make Crawler queue in Azure separate from Azure results storage#591elrayle merged 6 commits intoclearlydefined:masterfrom
elrayle merged 6 commits intoclearlydefined:masterfrom
Conversation
By adding a separate connection string we can host the queues separately from the crawler
hopefully more intention revealing
elrayle
added a commit
that referenced
this pull request
Aug 12, 2024
Make Crawler queue in Azure separate from Azure results storage
Collaborator
|
@ljones140 @elrayle Could you please also update documentation regarding the newly introduced environment variable? |
Contributor
Author
Apologies for missing that, I will create a new PR |
Contributor
Author
|
@qtomlinson PR on the operations documentation for the new env var clearlydefined/operations#88 |
Collaborator
|
@ljones140 Thank you for keeping the docs up to date! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Makes the crawler queue configurable as a separate connection string from the Azure storage account.
By setting the env var connection string
CRAWLER_QUEUE_AZURE_CONNECTION_STRINGwe can host the queues separately from the crawler.Why
Currently anyone who has access to CD's Azure account can access the queues of anyone else who is hosting a crawler and submitting results to CD's azure storage account.
This could lead to security issues if sensitive data leaked into the crawler queues.
Anything could be added to the queue by external entities with with access to the CD storage account.