Make scancode parallelism configurable#612
Merged
Conversation
ljones140
approved these changes
Oct 24, 2024
elrayle
requested changes
Oct 24, 2024
Collaborator
elrayle
left a comment
elrayle
left a comment
There was a problem hiding this comment.
One change requested, then this looks good.
Co-authored-by: E. Lynette Rayle <elrayle@users.noreply.github.com>
elrayle
approved these changes
Oct 24, 2024
Collaborator
elrayle
left a comment
elrayle
left a comment
There was a problem hiding this comment.
Thanks for making this configurable. This will really help with long term maintenance and scalability as needed.
elrayle
approved these changes
Oct 24, 2024
Collaborator
elrayle
left a comment
elrayle
left a comment
There was a problem hiding this comment.
Needs quotes around config name.
config/cdConfig.js
Outdated
| ], | ||
| timeout: 1000, | ||
| processes: 2, | ||
| processes: Number(config.get(CRAWLER_SCANCODE_PARALLELISM) || process.env.CRAWLER_SCANCODE_PARALLELISM) || 2, |
Collaborator
There was a problem hiding this comment.
Suggested change
| processes: Number(config.get(CRAWLER_SCANCODE_PARALLELISM) || process.env.CRAWLER_SCANCODE_PARALLELISM) || 2, | |
| processes: Number(config.get('CRAWLER_SCANCODE_PARALLELISM') || process.env.CRAWLER_SCANCODE_PARALLELISM) || 2, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #609
Replaces #611