Separate crawler queue connection from harvest#633
Merged
RomanIakovlev merged 1 commit intoroman/azure_sdkfrom Feb 11, 2025
Merged
Separate crawler queue connection from harvest#633RomanIakovlev merged 1 commit intoroman/azure_sdkfrom
RomanIakovlev merged 1 commit intoroman/azure_sdkfrom
Conversation
So we have the ability to have an harvest connection with connections string and queues with azure SPN
RomanIakovlev
approved these changes
Feb 11, 2025
Contributor
RomanIakovlev
left a comment
RomanIakovlev
left a comment
There was a problem hiding this comment.
Thanks! Looks good to me.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change is intended to give the ability to have a separate azblob connection to harvest blobs and crawler queues.
Organizations that run the crawler independently need to submit harvest results to CD Azure harvest but use their own Azure queues for crawler work queues.
By adding a boolean
isSpnAuthto thestorageQueueconfig it allows us to have crawler queues using a Azure SPN while having harvest blobs using a connection string. Without this it would have fallen back to theaz_blob.connectionwhich is the harvest results blob.