set value to return as docker-image-name-with-tag#107
Merged
Conversation
elrayle
force-pushed
the
elr/workflow
branch
2 times, most recently
from
4829e4a to
59113f3
Compare
ljones140
reviewed
Oct 29, 2024
| docker_image_tags="${{ inputs.docker-hub-username }}/${{ env.IMAGE_NAME }}" | ||
| echo "DOCKER_IMAGE_TAGS=${{ env.DOCKER_IMAGE_TAGS }}, $docker_image_tags" >> $GITHUB_ENV | ||
| # use Docker Hub image if it is created by overwriting DOCKER_IMAGE_TO_USE | ||
| echo "DOCKER_IMAGE_TO_USE=$docker_image_tags" >> $GITHUB_ENV |
Contributor
There was a problem hiding this comment.
Nice so the explicit DOCKER_IMAGE_TO_USE fixes the bug I introduced?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The build failed to deploy for service-api. The ultimate cause was that the output
docker-image-name-with-tagwas not getting set. The value of this output needs to be the docker image that will be used for the deployment.For service-api this is the ghcr image for both dev and prod.
For the crawler, it will use ghcr image for dev and Docker Hub image for prod. (at least for now)
This updates the version number to 3.1.2.
Follow on work
CC: @ljones140 for review