Repository navigation
Say when each kept rule was last updated - #407
Merged
Merged
Conversation
Rules set to Every time you connect now say when they last synced in Kept on this phone, such as "Updated 2 hours ago", from the time the sync store already keeps. It's for background sync, which updates them without the user watching. Rules kept as they are don't show it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01R2bAq6kZW6eyymkA3zsd4p
Store screenshotsFrom run 42293795183, against clementine-it. Left: the store listing of the latest release, v13.12, which shows the dark theme. Right: this pull request, dark and light. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

































The first of two PRs for background sync. iOS-Remote#81 does the same on iOS. Once the phone updates what's kept on its own, without the user watching, Kept on this phone should say when that last happened.
Rules set to Every time you connect now read, for example, "Every time you connect · Updated 2 hours ago · 12 songs, 80 MB". The time comes from
SyncRule.lastSyncedAt, which the sync store already keeps andSyncEnginesets on each rule that syncs, so no store change is needed.DateUtils.getRelativeTimeSpanStringwrites the relative time, and anything under a minute says "Updated just now". Rules kept as they are don't show it, because they aren't updated.The two new strings have notes for translators that match the iOS client's. Like the rest of media sync, this is behind the testing features, so it has no release note.
Tests
DownloadsScreenTest.saysWhenWhatsUpdatedLastWas🤖 Generated with Claude Code
https://claude.ai/code/session_01R2bAq6kZW6eyymkA3zsd4p