fix global steps tracking & --save_steps intermittent saves (#6, #8)#11
Merged
cloneofsimo merged 2 commits intocloneofsimo:masterfrom Dec 10, 2022
Merged
Conversation
Contributor
Author
|
I accidentally included the fix for #10 in this PR, too. |
…r versions of accelerate (which don't support it)
Owner
|
Thanks for the fix! Interesting though, because this wasn't a problem for me. Was it still the case with accumulate_gradient size 1? |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Underlying bug was that "global_steps" was only incrementing (by 1) at the end of each epoch. This lead to behavior where train_lora_dreambooth would compute twice as many steps as requested (which I & others on Reddit have seen).
I chose to use "--save_steps" as a hint, and only have it save at the end of epochs. So if an epoch is 120 steps, and you ask for "--save_steps 100", you'll get a save at step=120, 240, etc...