Privacy & Security#399
Merged
Merged
Conversation
Signed-off-by: Day, Jem <jday@paypal.com>
This was referenced Mar 12, 2019
Closed
duglin
reviewed
Mar 12, 2019
duglin
reviewed
Mar 12, 2019
duglin
reviewed
Mar 12, 2019
| * Data | ||
|
|
||
| Domain specific [data](#data) *SHOULD* be encoded to restrict visibility to | ||
| trusted parties. |
Collaborator
There was a problem hiding this comment.
We may need to add something like: The exact mechanism by which it is encoded is out of scope of this specification.
Contributor
There was a problem hiding this comment.
What does "encoded" mean here?
Contributor
Author
There was a problem hiding this comment.
I've changed the wording - please take another look.
@clemensv I was simply trying to avoid the word 'encrypt' as i felt that was to loaded.
Collaborator
|
Minor edits, but overall I like the direction it's headed - thanks! |
duglin
reviewed
Mar 15, 2019
Signed-off-by: Day, Jem <jday@paypal.com>
Collaborator
|
LGTM Can you add this new section to the TOC? |
Signed-off-by: Day, Jem <jday@paypal.com>
Collaborator
|
Still LGTM |
Signed-off-by: Day, Jem <jday@paypal.com>
Collaborator
|
Approved on the 3/21/2019 call - with the s/encode/encrypt/ change. Possible future PRs may wordsmith this further. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Day, Jem jday@paypal.com