group: Removes use of elliptic Marshal and Unmarshal functions.#556
Merged
armfazh merged 1 commit intocloudflare:mainfrom Jul 21, 2025
Merged
group: Removes use of elliptic Marshal and Unmarshal functions.#556armfazh merged 1 commit intocloudflare:mainfrom
armfazh merged 1 commit intocloudflare:mainfrom
Conversation
bwesterb
requested changes
Jul 17, 2025
group/short.go
Outdated
| ec := e.wG.c | ||
| if e.wG == P384 { | ||
| ec = elliptic.P384() | ||
| } |
Contributor
Author
There was a problem hiding this comment.
this is because the ECDH function checks whether ec is an elliptic.Curve object.
I made changes to avoid this check.
bwesterb
approved these changes
Jul 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes use of elliptic Marshal and Unmarshal functions.
Fixes #549