Skip to content

fix the lockfile#6731

Open
vicb wants to merge 1 commit intomainfrom
vicb/fix-lockfile
Open

fix the lockfile#6731
vicb wants to merge 1 commit intomainfrom
vicb/fix-lockfile

Conversation

@vicb
Copy link
Copy Markdown
Contributor

@vicb vicb commented May 6, 2026

It looks like the lockfile was not updated after #6389

@vicb vicb requested review from a team as code owners May 6, 2026 06:31
@vicb vicb requested a review from NuroDev May 6, 2026 06:31
@ask-bonk
Copy link
Copy Markdown
Contributor

ask-bonk Bot commented May 6, 2026

The lockfile specifiers in the diff exactly match the package.json files. This is a straightforward lockfile sync — all the package.json files were updated in PR #6389 but the pnpm-lock.yaml wasn't regenerated to match. The lockfile update here correctly reflects the dependency versions declared in the package.json files.

LGTM

github run

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 6, 2026

The generated output of @cloudflare/workers-types has been changed by this PR. If this is intentional, run just generate-types to update the snapshot. Alternatively, you can download the full generated types:

Full Type Diff

Copy link
Copy Markdown
Member

@NuroDev NuroDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine and make sense.
But CI seems to be massively failing @vicb

@NuroDev NuroDev changed the title fix the lockflie fix the lockfile May 6, 2026
@mikea
Copy link
Copy Markdown
Contributor

mikea commented May 6, 2026

@jasnell something has changed in node types for http.Agend upstream.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants