Skip to content

Add served_by_colo to D1 tracing spans#6733

Merged
lambrospetrou merged 2 commits intomainfrom
lambros/d1-tracing-extra-tags
May 6, 2026
Merged

Add served_by_colo to D1 tracing spans#6733
lambrospetrou merged 2 commits intomainfrom
lambros/d1-tracing-extra-tags

Conversation

@lambrospetrou
Copy link
Copy Markdown
Contributor

@lambrospetrou lambrospetrou requested review from a team as code owners May 6, 2026 11:28
Copy link
Copy Markdown
Contributor

@ask-bonk ask-bonk Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tiny grammar nit, otherwise LGTM — clean and consistent with the existing served_by_region / served_by_primary pattern.

Comment thread src/cloudflare/internal/d1-api.ts Outdated
@ask-bonk
Copy link
Copy Markdown
Contributor

ask-bonk Bot commented May 6, 2026

Review posted on PR #6733. The PR adds served_by_colo to D1 tracing spans — a clean, additive change that follows the existing patterns exactly. The only finding was a minor grammar nit in the doc comment ("three letters" → "three-letter"). Tests are thorough, covering all span assertions with the new field, and the mock is updated accordingly.

github run

Co-authored-by: ask-bonk[bot] <249159057+ask-bonk[bot]@users.noreply.github.com>
@lambrospetrou lambrospetrou merged commit 06abbb8 into main May 6, 2026
26 checks passed
@lambrospetrou lambrospetrou deleted the lambros/d1-tracing-extra-tags branch May 6, 2026 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants