Add VPC Services bindings#10647
Merged
Merged
Conversation
🦋 Changeset detectedLatest commit: 1d660a2 The changes in this PR will be included in the next version bump. This PR includes changesets to release 5 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
penalosa
reviewed
Sep 15, 2025
Contributor
penalosa
left a comment
penalosa
left a comment
There was a problem hiding this comment.
This will need a Miniflare plugin to support Mixed Mode
create-cloudflare
@cloudflare/kv-asset-handler
miniflare
@cloudflare/pages-shared
@cloudflare/unenv-preset
@cloudflare/vite-plugin
@cloudflare/vitest-pool-workers
@cloudflare/workers-editor-shared
wrangler
commit: |
penalosa
reviewed
Sep 17, 2025
penalosa
reviewed
Sep 17, 2025
penalosa
approved these changes
Sep 17, 2025
penalosa
approved these changes
Sep 17, 2025
xortive
reviewed
Sep 17, 2025
Contributor
|
For posterity, let's follow up with E2E tests here as soon as we can |
xortive
reviewed
Sep 18, 2025
Contributor
Author
|
because this feature is gated to internal emails until next week, e2e testing only works with a User token (which has email claims). CI is set up with an Account token and thus the e2e test for VPC fails. I have attached screenshots of a passing test below and have set a reminder to enable the test next week once it can work with Account tokens 
|
petebacondarwin
force-pushed
the
efalcao/vpc-services-binding
branch
from
b0d3fe5 to
64b7da2
Compare
Contributor
|
Don't have approval perms on workers-sdk, but this looks good from VPC side |
dario-piotrowicz
force-pushed
the
efalcao/vpc-services-binding
branch
2 times, most recently
from
bb758ea to
dd9a4e7
Compare
`"vpc_services": [{ "binding": "MYAPI", "service_id": "0199295b-b3ac-7760-8246-bca40877b3e9" }]`
- removed connectivity from the name - made `type` option required - default ports for http/https - removed tcp service type - made resolver-ips optional
petebacondarwin
force-pushed
the
efalcao/vpc-services-binding
branch
from
dd9a4e7 to
1d660a2
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements WVPC-42.
Add VPC Services bindings
"vpc_services": [{ "binding": "MYAPI", "service_id": "0199295b-b3ac-7760-8246-bca40877b3e9" }]Approval: CR-1304537