Skip to content

Apply vite-plugin-cloudflare:nodejs-compat-warnings plugin only to relevant environments#11847

Merged
jamesopstad merged 2 commits intomainfrom
james/apply-to-environment
Jan 9, 2026
Merged

Apply vite-plugin-cloudflare:nodejs-compat-warnings plugin only to relevant environments#11847
jamesopstad merged 2 commits intomainfrom
james/apply-to-environment

Conversation

@jamesopstad
Copy link
Copy Markdown
Contributor

Apply vite-plugin-cloudflare:nodejs-compat-warnings plugin only to relevant environments.


  • Tests
    • Tests included/updated
    • Tests not necessary because: minor optimisation
  • Public documentation
    • Cloudflare docs PR(s):
    • Documentation not necessary because: optimisation

A picture of a cute animal (not mandatory, but encouraged)

@jamesopstad jamesopstad requested a review from a team as a code owner January 9, 2026 12:31
@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Jan 9, 2026

🦋 Changeset detected

Latest commit: 0df5a46

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@claude
Copy link
Copy Markdown
Contributor

claude bot commented Jan 9, 2026

Claude finished @jamesopstad's task —— View job


Changeset Review

✅ All changesets look good

The changeset .changeset/young-wings-think.md has been reviewed and passes all validation criteria:

  • Version Type: ✅ Correctly uses patch for an optimization
  • Package: ✅ @cloudflare/vite-plugin is correct
  • Changelog Quality: ✅ Clear title and informative description explaining the optimization
  • Markdown Headers: ✅ No problematic h1/h2/h3 headers used
  • Format: ✅ Follows the proper changeset structure

The description clearly explains what the optimization does (only applying the plugin to relevant environments) and provides context about when it doesn't need to run (client environment or environments with nodejs_compat flag).


@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new bot commented Jan 9, 2026

create-cloudflare

npm i https://pkg.pr.new/create-cloudflare@11847

@cloudflare/kv-asset-handler

npm i https://pkg.pr.new/@cloudflare/kv-asset-handler@11847

miniflare

npm i https://pkg.pr.new/miniflare@11847

@cloudflare/pages-shared

npm i https://pkg.pr.new/@cloudflare/pages-shared@11847

@cloudflare/unenv-preset

npm i https://pkg.pr.new/@cloudflare/unenv-preset@11847

@cloudflare/vite-plugin

npm i https://pkg.pr.new/@cloudflare/vite-plugin@11847

@cloudflare/vitest-pool-workers

npm i https://pkg.pr.new/@cloudflare/vitest-pool-workers@11847

@cloudflare/workers-editor-shared

npm i https://pkg.pr.new/@cloudflare/workers-editor-shared@11847

@cloudflare/workers-utils

npm i https://pkg.pr.new/@cloudflare/workers-utils@11847

wrangler

npm i https://pkg.pr.new/wrangler@11847

commit: 0df5a46

@jamesopstad jamesopstad force-pushed the james/apply-to-environment branch from 96ace2b to 0df5a46 Compare January 9, 2026 12:35
@github-project-automation github-project-automation bot moved this from Untriaged to Approved in workers-sdk Jan 9, 2026
@jamesopstad jamesopstad merged commit 46e09a6 into main Jan 9, 2026
35 checks passed
@github-project-automation github-project-automation bot moved this from Approved to Done in workers-sdk Jan 9, 2026
@jamesopstad jamesopstad deleted the james/apply-to-environment branch January 9, 2026 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants