Do not warn user when using a redirected config that came from a config with multiple environments#11848
Merged
petebacondarwin merged 5 commits intomainfrom Jan 10, 2026
Conversation
🦋 Changeset detectedLatest commit: cde4e65 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
Claude finished @petebacondarwin's task —— View job Changeset Review
✅ All changesets look good The changeset
|
petebacondarwin
commented
Jan 9, 2026
| export default { | ||
| async fetch(request, env) { | ||
| return new Response("Generated: " + env.generated ?? false); | ||
| return new Response("Generated: " + (env.generated ?? false)); |
Contributor
Author
There was a problem hiding this comment.
This is an unrelated minor fix to the worker code of this fixture
petebacondarwin
commented
Jan 9, 2026
| expect(output.stdout).toContain( | ||
| ` - Deploy configuration file: ".wrangler/deploy/config.json"` | ||
| ); | ||
| expect(output.stderr).toMatchInlineSnapshot(`""`); |
Contributor
Author
There was a problem hiding this comment.
This is the key check that fails without the fix in this PR
create-cloudflare
@cloudflare/kv-asset-handler
miniflare
@cloudflare/pages-shared
@cloudflare/unenv-preset
@cloudflare/vite-plugin
@cloudflare/vitest-pool-workers
@cloudflare/workers-editor-shared
@cloudflare/workers-utils
wrangler
commit: |
vicb
reviewed
Jan 9, 2026
vicb
reviewed
Jan 9, 2026
vicb
approved these changes
Jan 9, 2026
…ig with multiple environments This reverts these lines https://github.com/cloudflare/workers-sdk/pull/10706/files#diff-c5b22ef21f285ccf53ba4a990d6fba5e40050aee0dbe5a0b6737852164771d06L174-L182 which were added as a refactor but cause the warning to be emitted incorrectly.
petebacondarwin
force-pushed
the
pbd/wrangler/redirected-config-env-check
branch
from
a3494ea to
2877382
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts these lines https://github.com/cloudflare/workers-sdk/pull/10706/files#diff-c5b22ef21f285ccf53ba4a990d6fba5e40050aee0dbe5a0b6737852164771d06L174-L182 which were added as a refactor but cause the warning to be emitted incorrectly.