[C3] fix: bump nuxi to 3.33.1 and fix E2E tests for template prompt#12528
[C3] fix: bump nuxi to 3.33.1 and fix E2E tests for template prompt#12528
Conversation
nuxi 3.31.0+ added an interactive template selection prompt to `nuxi init`, causing E2E tests to hang and timeout. Pass `--template minimal` via E2E flags to skip the prompt, matching the pattern used by Astro and Svelte. Also updates the modules prompt matcher regex for the new wording in nuxi 3.31+.
🦋 Changeset detectedLatest commit: 7ab799b The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Claude finished @ascorbic's task —— View job Changeset Review
The changeset description needs improvement: Current description: Problem: This is too brief and doesn't explain the user impact or the reason for the change. According to Suggestion: The changeset should explain that this bump is necessary to avoid E2E test timeouts caused by interactive prompts in nuxi 3.31.0+. While the dependency version bump itself is the change, users benefit from understanding why this update was needed. Something like: ---
"create-cloudflare": patch
---
Bump nuxi from 3.30.0 to 3.33.1
nuxi 3.31.0+ added an interactive template selection prompt that would cause
C3 tests to hang. This update ensures compatibility with the latest nuxi version
and includes test configuration updates to handle the new interactive prompts.All other validation criteria pass:
|
create-cloudflare
@cloudflare/kv-asset-handler
miniflare
@cloudflare/pages-shared
@cloudflare/unenv-preset
@cloudflare/vite-plugin
@cloudflare/vitest-pool-workers
@cloudflare/workers-editor-shared
@cloudflare/workers-utils
wrangler
commit: |
Supersedes #11544.
nuxi 3.31.0+ (nuxt/cli#1147) added an interactive template selection prompt to
nuxi init. This causes the C3 nuxt E2E tests to hang waiting for input and eventually timeout after 1200s.Changes:
flags: ["--template", "minimal"]to all three nuxt E2E test entries, matching the pattern used by Astro (--template blog) and Svelte (--template minimal). The user still sees the interactive template prompt when running C3 normally./Would you like to install any of the official modules\?/to/Would you like to .* install .*modules\?/to handle the new wording in nuxi 3.31+ ("Would you like to browse and install modules?")