Skip to content

WC-5744 [previews] fix: wrangler preview base-config flag inheritance - #15153

Merged
petebacondarwin merged 2 commits into
cloudflare:mainfrom
podonnell-dev:podonnell/WC-5744-preview-secrets-flags
Aug 16, 2026
Merged

petebacondarwin merged 2 commits into
cloudflare:mainfrom
podonnell-dev:podonnell/WC-5744-preview-secrets-flags

Conversation

@podonnell-dev

Copy link
Copy Markdown
Contributor

Fixes WC-5744

[private beta] wrangler preview base-config commands incorrectly accept script as a positional. This results in weird behavior like:

✘ [ERROR] Not enough non-option arguments: got 0, need at least 1

wrangler preview base-config secret put <key>

Create or update a secret variable on the Preview base config [private beta]

POSITIONALS
  script  The path to an entry point for your Worker  [string]
  key     The secret name to be accessible in the Worker  [string] [required] 

This behavior is only present since we use wrangler preview <script> rather than wrangler preview deploy - so ignoring this manually.


  • Tests
    • Tests included/updated
    • Automated tests not possible - manual testing has been completed as follows:
    • Additional testing not necessary because:
  • Public documentation
    • Cloudflare docs PR(s):
    • Documentation not necessary because: private beta

A picture of a cute animal (not mandatory, but encouraged)

@changeset-bot

changeset-bot Bot commented Aug 12, 2026 •

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: dd324c5

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
wrangler Patch
@cloudflare/vite-plugin Patch
@cloudflare/vitest-pool-workers Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-project-automation github-project-automation Bot moved this to Untriaged in workers-sdk Aug 12, 2026
@workers-devprod
workers-devprod requested review from a team and petebacondarwin and removed request for a team August 12, 2026 18:17
@workers-devprod

workers-devprod commented Aug 12, 2026 •

Copy link
Copy Markdown
Contributor

Codeowners approval required for this PR:

  • ✅ @cloudflare/wrangler
Show detailed file reviewers

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no potential bugs to report.

View in Devin Review to see 1 additional finding.

Open in Devin Review

@pkg-pr-new

pkg-pr-new Bot commented Aug 12, 2026 •

Copy link
Copy Markdown
@cloudflare/autoconfig

npm i https://pkg.pr.new/@cloudflare/autoconfig@15153

@cloudflare/build-output-utils

npm i https://pkg.pr.new/@cloudflare/build-output-utils@15153

@cloudflare/config

npm i https://pkg.pr.new/@cloudflare/config@15153

create-cloudflare

npm i https://pkg.pr.new/create-cloudflare@15153

@cloudflare/deploy-helpers

npm i https://pkg.pr.new/@cloudflare/deploy-helpers@15153

@cloudflare/kv-asset-handler

npm i https://pkg.pr.new/@cloudflare/kv-asset-handler@15153

miniflare

npm i https://pkg.pr.new/miniflare@15153

@cloudflare/pages-functions

npm i https://pkg.pr.new/@cloudflare/pages-functions@15153

@cloudflare/pages-shared

npm i https://pkg.pr.new/@cloudflare/pages-shared@15153

@cloudflare/unenv-preset

npm i https://pkg.pr.new/@cloudflare/unenv-preset@15153

@cloudflare/vite-plugin

npm i https://pkg.pr.new/@cloudflare/vite-plugin@15153

@cloudflare/vitest-pool-workers

npm i https://pkg.pr.new/@cloudflare/vitest-pool-workers@15153

@cloudflare/workers-auth

npm i https://pkg.pr.new/@cloudflare/workers-auth@15153

@cloudflare/workers-editor-shared

npm i https://pkg.pr.new/@cloudflare/workers-editor-shared@15153

@cloudflare/workers-utils

npm i https://pkg.pr.new/@cloudflare/workers-utils@15153

wrangler

npm i https://pkg.pr.new/wrangler@15153

commit: dd324c5

@petebacondarwin

Copy link
Copy Markdown
Contributor

Formatting needs fixing

@podonnell-dev
podonnell-dev force-pushed the podonnell/WC-5744-preview-secrets-flags branch 2 times, most recently from 684ba79 to a809d1d Compare August 14, 2026 13:05
@petebacondarwin
petebacondarwin force-pushed the podonnell/WC-5744-preview-secrets-flags branch from a809d1d to cc4907f Compare August 14, 2026 16:32

@workers-devprod workers-devprod left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codeowners reviews satisfied

@github-project-automation github-project-automation Bot moved this from Untriaged to Approved in workers-sdk Aug 14, 2026
@petebacondarwin
petebacondarwin force-pushed the podonnell/WC-5744-preview-secrets-flags branch from cc4907f to dd324c5 Compare August 16, 2026 20:06
@petebacondarwin
petebacondarwin merged commit 265256a into cloudflare:main Aug 16, 2026
54 checks passed
@github-project-automation github-project-automation Bot moved this from Approved to Done in workers-sdk Aug 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants