Repository navigation
WC-5744 [previews] fix: wrangler preview base-config flag inheritance - #15153
Merged
petebacondarwin merged 2 commits intoAug 16, 2026
Merged
petebacondarwin merged 2 commits into
petebacondarwin merged 2 commits into
Conversation
🦋 Changeset detectedLatest commit: dd324c5 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
workers-devprod
requested review from
a team and
petebacondarwin
and removed request for
a team
August 12, 2026 18:17
Contributor
|
Codeowners approval required for this PR:
Show detailed file reviewers |
@cloudflare/autoconfig
@cloudflare/build-output-utils
@cloudflare/config
create-cloudflare
@cloudflare/deploy-helpers
@cloudflare/kv-asset-handler
miniflare
@cloudflare/pages-functions
@cloudflare/pages-shared
@cloudflare/unenv-preset
@cloudflare/vite-plugin
@cloudflare/vitest-pool-workers
@cloudflare/workers-auth
@cloudflare/workers-editor-shared
@cloudflare/workers-utils
wrangler
commit: |
GregBrimble
approved these changes
Aug 12, 2026
Contributor
|
Formatting needs fixing |
podonnell-dev
force-pushed
the
podonnell/WC-5744-preview-secrets-flags
branch
2 times, most recently
from
August 14, 2026 13:05
684ba79 to
a809d1d
Compare
petebacondarwin
force-pushed
the
podonnell/WC-5744-preview-secrets-flags
branch
from
August 14, 2026 16:32
a809d1d to
cc4907f
Compare
petebacondarwin
approved these changes
Aug 14, 2026
workers-devprod
approved these changes
Aug 14, 2026
workers-devprod
left a comment
Contributor
There was a problem hiding this comment.
Codeowners reviews satisfied
petebacondarwin
force-pushed
the
podonnell/WC-5744-preview-secrets-flags
branch
from
August 16, 2026 20:06
cc4907f to
dd324c5
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes WC-5744
[private beta]
wrangler preview base-configcommands incorrectly acceptscriptas a positional. This results in weird behavior like:This behavior is only present since we use
wrangler preview <script>rather thanwrangler preview deploy- so ignoring this manually.A picture of a cute animal (not mandatory, but encouraged)