Skip to content

[wrangler] Use FedRAMP container registries - #15196

Merged
dario-piotrowicz merged 1 commit into
mainfrom
nafeez/TASK-wrangler-fedramp-registry
Aug 16, 2026
Merged

dario-piotrowicz merged 1 commit into
mainfrom
nafeez/TASK-wrangler-fedramp-registry

Conversation

@skepticfx

@skepticfx skepticfx commented Aug 14, 2026 •

Copy link
Copy Markdown
Member

Select the managed container registry from both the Wrangler compliance region and API environment, while preserving the explicit registry override. Propagate compliance config through deploy, build, image, registry, local dev, and Vite plugin paths.


Fix Wrangler's managed container registry selection when compliance_region or CLOUDFLARE_COMPLIANCE_REGION is set to fedramp_high.

Previously Wrangler selected the FedRAMP High API endpoint, but container workflows could continue using the public managed registry, resulting in registry lookup failures. The registry is now selected from both the compliance region and API environment:

Public production: registry.cloudflare.com

Public staging: staging.registry.cloudflare.com

FedRAMP High production: registry.fed.cloudflare.com

FedRAMP High staging: staging.registry.fed.cloudflare.com

The compliance config is propagated through container builds, pushes, deployments, image and registry commands, local development, and the Vite plugin. CLOUDFLARE_CONTAINER_REGISTRY remains the highest-priority override.


  • Tests
    • Tests included/updated
    • Automated tests not possible - manual testing has been completed as follows:
    • Additional testing not necessary because:
  • Public documentation
    • Cloudflare docs PR(s):
    • Documentation not necessary because: bug fix establishing the user-expected behavior

A picture of a cute animal (not mandatory, but encouraged)

@changeset-bot

changeset-bot Bot commented Aug 14, 2026 •

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 59d1808

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@cloudflare/vite-plugin Patch
wrangler Patch
@cloudflare/vitest-pool-workers Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-project-automation github-project-automation Bot moved this to Untriaged in workers-sdk Aug 14, 2026
@skepticfx
skepticfx requested a review from a team August 14, 2026 17:49
@workers-devprod
workers-devprod requested review from a team and dario-piotrowicz and removed request for a team August 14, 2026 17:49
@workers-devprod

workers-devprod commented Aug 14, 2026 •

Copy link
Copy Markdown
Contributor

Codeowners approval required for this PR:

  • ✅ @cloudflare/cloudchamber
  • ✅ @cloudflare/wrangler
Show detailed file reviewers

@ask-bonk

ask-bonk Bot commented Aug 14, 2026

Copy link
Copy Markdown
Contributor

The change is complete and consistent. All production call sites propagate the compliance config, the registry naming logic (registry.fed.cloudflare.com etc.) is derived correctly via the shared getComplianceRegionSubdomain, the CLOUDFLARE_CONTAINER_REGISTRY override retains highest priority, and tests cover the new cases including the override precedence.

I verified the changes are for PR #15196 (branch nafeez/TASK-wrangler-fedramp-registry, commit 9f8ea9d). I found no logic bugs, security issues, backward-compatibility violations, or incorrect API behavior. The compliance config is threaded through every relevant path, optional params default to environment-driven behavior preserving existing semantics, and the override precedence is tested.

LGTM

github run

@pkg-pr-new

pkg-pr-new Bot commented Aug 14, 2026 •

Copy link
Copy Markdown
@cloudflare/autoconfig

npm i https://pkg.pr.new/@cloudflare/autoconfig@15196

@cloudflare/build-output-utils

npm i https://pkg.pr.new/@cloudflare/build-output-utils@15196

@cloudflare/config

npm i https://pkg.pr.new/@cloudflare/config@15196

create-cloudflare

npm i https://pkg.pr.new/create-cloudflare@15196

@cloudflare/deploy-helpers

npm i https://pkg.pr.new/@cloudflare/deploy-helpers@15196

@cloudflare/kv-asset-handler

npm i https://pkg.pr.new/@cloudflare/kv-asset-handler@15196

miniflare

npm i https://pkg.pr.new/miniflare@15196

@cloudflare/pages-functions

npm i https://pkg.pr.new/@cloudflare/pages-functions@15196

@cloudflare/pages-shared

npm i https://pkg.pr.new/@cloudflare/pages-shared@15196

@cloudflare/unenv-preset

npm i https://pkg.pr.new/@cloudflare/unenv-preset@15196

@cloudflare/vite-plugin

npm i https://pkg.pr.new/@cloudflare/vite-plugin@15196

@cloudflare/vitest-pool-workers

npm i https://pkg.pr.new/@cloudflare/vitest-pool-workers@15196

@cloudflare/workers-auth

npm i https://pkg.pr.new/@cloudflare/workers-auth@15196

@cloudflare/workers-editor-shared

npm i https://pkg.pr.new/@cloudflare/workers-editor-shared@15196

@cloudflare/workers-utils

npm i https://pkg.pr.new/@cloudflare/workers-utils@15196

wrangler

npm i https://pkg.pr.new/wrangler@15196

commit: 59d1808

devin-ai-integration[bot]

This comment was marked as resolved.

@skepticfx
skepticfx force-pushed the nafeez/TASK-wrangler-fedramp-registry branch from 9f8ea9d to 0c64224 Compare August 15, 2026 15:59
@github-actions

github-actions Bot commented Aug 15, 2026 •

Copy link
Copy Markdown
Contributor

✅ All changesets look good

@dario-piotrowicz dario-piotrowicz left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 😄

Comment thread packages/containers-shared/src/knobs.ts Resolved

@workers-devprod workers-devprod left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codeowners reviews satisfied

Select the managed container registry from both the Wrangler compliance region and API environment, while preserving the explicit registry override. Propagate compliance config through deploy, build, image, registry, local dev, and Vite plugin paths.
@skepticfx
skepticfx force-pushed the nafeez/TASK-wrangler-fedramp-registry branch from 0c64224 to 59d1808 Compare August 16, 2026 18:22
@dario-piotrowicz
dario-piotrowicz merged commit 8fb2b87 into main Aug 16, 2026
59 checks passed
@dario-piotrowicz
dario-piotrowicz deleted the nafeez/TASK-wrangler-fedramp-registry branch August 16, 2026 20:18
@github-project-automation github-project-automation Bot moved this from Untriaged to Done in workers-sdk Aug 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants