Repository navigation
Conversation
🦋 Changeset detectedLatest commit: 17faf17 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
workers-devprod
requested review from
a team and
petebacondarwin
and removed request for
a team
August 15, 2026 19:38
Contributor
|
Codeowners approval required for this PR:
Show detailed file reviewers
|
@cloudflare/autoconfig
@cloudflare/build-output-utils
@cloudflare/config
create-cloudflare
@cloudflare/deploy-helpers
@cloudflare/kv-asset-handler
miniflare
@cloudflare/pages-functions
@cloudflare/pages-shared
@cloudflare/unenv-preset
@cloudflare/vite-plugin
@cloudflare/vitest-pool-workers
@cloudflare/workers-auth
@cloudflare/workers-editor-shared
@cloudflare/workers-utils
wrangler
commit: |
Contributor
|
Was this already fixed by #15185? |
Contributor
|
Closing as this has been resolved already. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #14942.
C3 writes today's date as the
compatibility_dateof a new project, but theworkerdthat the scaffolded project pins can be a day or two behind today. When it is, the project fails to start on its very firstdev, before the user has written any code, with:Editing the date down by hand fixes it, but the error names a date C3 itself generated, so it reads as "the runtime is broken" rather than "the scaffold is a couple of days ahead." This is the same failure mode as #1948, just from C3 rather than
wrangler init, so that earlier fix doesn't cover this path.getWorkerdCompatibilityDatenow clamps today's date to the newest date the bundledworkerdsupports.workerdis versioned as1.YYYYMMDD.x, where the middle component is exactly that date, so the ceiling is read fromworkerd/package.json(added as a dependency, mirroring howgit.tsalready reads the version out ofwrangler/package.json). If the version string ever fails to parse, it falls back to today's date unchanged rather than guessing. C3 pins the sameworkerdit scaffolds into the project, so the date it caps to is the one the new project will actually run against.I verified it against the currently bundled
workerd(1.20260811.1): with today at 2026-08-15 the generated date is now2026-08-11instead of2026-08-15. Added two unit tests, one for the normal case where today is within range and one for the clamp, and checked the clamp test fails onmainand passes with this change.oxlint,oxfmtand the package's existing compat-date tests are all green.