[wrangler] Allows uploads with both cron triggers and smart placement enabled#4219
Conversation
🦋 Changeset detectedLatest commit: 471aae5 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/6645687983/npm-package-wrangler-4219You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/6645687983/npm-package-wrangler-4219Or you can use npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/6645687983/npm-package-wrangler-4219 dev path/to/script.jsAdditional artifacts:npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/6645687983/npm-package-cloudflare-pages-shared-4219Note that these links will no longer work once the GitHub Actions artifact expires.
| Please ensure constraints are pinned, and |
Codecov Report
@@ Coverage Diff @@
## main #4219 +/- ##
==========================================
+ Coverage 75.33% 75.36% +0.02%
==========================================
Files 223 223
Lines 12294 12287 -7
Branches 3177 3176 -1
==========================================
- Hits 9262 9260 -2
+ Misses 3032 3027 -5
|
71772aa to
1fb43ac
Compare
Revert "Prevents uploads with both cron triggers and smart placement enabled (cloudflare#3390)" This reverts commit b5b46b4.
1fb43ac to
471aae5
Compare
|
I am getting "Placement is not supported with cron triggers" was this reverted again ? |
Revert "Prevents uploads with both cron triggers and smart placement enabled (#3390)"
This reverts commit b5b46b4.
Fixes WP-591.
What this PR solves / how to test:
Lifts a temporary restriction that was put in place because of a bug with smart placement that made it incompatible with cron triggers. That bug has been fixed and users are now free to use smart placement and cron triggers together.
Associated docs issue(s)/PR(s):
Author has included the following, where applicable:
Reviewer is to perform the following, as applicable:
Note for PR author:
We want to celebrate and highlight awesome PR review! If you think this PR received a particularly high-caliber review, please assign it the label
highlight pr reviewso future reviewers can take inspiration and learn from it.