wrangler: Hyperdrive dev bindings by tmthecoder · Pull Request #4222 · cloudflare/workers-sdk

tmthecoder · 2023-10-18T17:54:40Z

Associated docs issue(s)/PR(s):

N/A

Author has included the following, where applicable:

Tests
Changeset (Changeset guidelines)

Reviewer is to perform the following, as applicable:

Checked for inclusion of relevant tests
Checked for inclusion of a relevant changeset
Checked for creation of associated docs updates
Manually pulled down the changes and spot-tested

Note for PR author:

We want to celebrate and highlight awesome PR review! If you think this PR received a particularly high-caliber review, please assign it the label highlight pr review so future reviewers can take inspiration and learn from it.

changeset-bot · 2023-10-18T17:54:44Z

🦋 Changeset detected

Latest commit: 7d5f3f4

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
wrangler	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

penalosa

Looking good! This should include some tests, ideally validating that this works end-to-end in local mode (have a look at the e2e folder for some example tests of Wrangler dev—ideally it would be good to validate that a mock postgres server is connected to by workerd)

packages/wrangler/src/config/environment.ts

codecov · 2023-10-26T18:04:04Z

Codecov Report

Merging #4222 (7d5f3f4) into main (a4a89ae) will decrease coverage by 0.01%.
Report is 15 commits behind head on main.
The diff coverage is 14.28%.

@@            Coverage Diff             @@
##             main    #4222      +/-   ##
==========================================
- Coverage   75.34%   75.34%   -0.01%     
==========================================
  Files         223      223              
  Lines       12341    12349       +8     
  Branches     3190     3194       +4     
==========================================
+ Hits         9298     9304       +6     
- Misses       3043     3045       +2

Files	Coverage Δ
packages/wrangler/src/dev/miniflare.ts	`60.35% <33.33%> (-0.49%)`	⬇️
packages/wrangler/src/dev.tsx	`82.40% <0.00%> (-1.34%)`	⬇️

... and 5 files with indirect coverage changes

github-actions · 2023-10-26T18:09:09Z

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/6775494867/npm-package-wrangler-4222

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/6775494867/npm-package-wrangler-4222

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/6775494867/npm-package-wrangler-4222 dev path/to/script.js

Additional artifacts:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/6775494867/npm-package-miniflare-4222

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/6775494867/npm-package-cloudflare-pages-shared-4222

Note that these links will no longer work once the GitHub Actions artifact expires.

wrangler@3.15.0 includes the following runtime dependencies:

Package	Constraint	Resolved
`miniflare`	workspace:*	3.20231025.1
`workerd`	1.20231030.0	1.20231030.0
`workerd --version`	1.20231030.0	2023-10-30

|

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

tmthecoder · 2023-10-27T14:37:24Z

@penalosa Should be all set with tests as well. However the socket test won't work until cloudflare/miniflare#727 is merged in & miniflare is bumped here due to a small address formatting bug I found in my initial implementation there

penalosa · 2023-10-27T15:18:09Z

packages/wrangler/e2e/dev.test.ts

+	it("connects to a socket", async () => {
+		server.on("connection", (sock) => {
+			sock.on("data", (data) => {
+				expect(new TextDecoder().decode(data)).toBe("test string");


Will this expect definitely run? What if the test exits too soon?

This may need wrapping in a new Promise() that's explicitly await in the test

Ah yeah, that makes sense. Just wrapped it in a promise

penalosa

LGTM! Let's wait to merge until Miniflare is released and bumped on Monday, so that tests will pass

tmthecoder · 2023-11-01T20:19:27Z

@penalosa Tests seem to pass locally now that miniflare is the latest in-workspace version. Are we able to rerun the flows here to make sure and then merge?

Skye-31 · 2023-11-02T08:58:12Z

packages/wrangler/e2e/dev.test.ts

 import crypto from "node:crypto";
+import * as nodeNet from "node:net";
 import path from "node:path";
+import { afterEach } from "node:test";


This should be from vitest

@Skye-31 Ah my bad, it should be changed now. Also fixed the formatting errors that caused tests to fail

tmthecoder · 2023-11-06T19:12:42Z

@rts-rob

tmthecoder requested a review from a team as a code owner October 18, 2023 17:54

tmthecoder force-pushed the tejas/add-hyperdrive-support branch from 50e87ad to 8dc7983 Compare October 18, 2023 18:03

tmthecoder force-pushed the tejas/add-hyperdrive-support branch from 8dc7983 to ff99153 Compare October 26, 2023 16:20

penalosa requested changes Oct 26, 2023

View reviewed changes

packages/wrangler/src/config/environment.ts Outdated Show resolved Hide resolved

tmthecoder force-pushed the tejas/add-hyperdrive-support branch from 29d33c7 to 59e071c Compare October 27, 2023 14:38

penalosa added e2e Run wrangler + vite-plugin e2e tests on a PR and removed e2e Run wrangler + vite-plugin e2e tests on a PR labels Oct 27, 2023

penalosa reviewed Oct 27, 2023

View reviewed changes

penalosa approved these changes Oct 27, 2023

View reviewed changes

tmthecoder force-pushed the tejas/add-hyperdrive-support branch 2 times, most recently from e6512ea to b1e7d8a Compare November 1, 2023 20:18

tmthecoder force-pushed the tejas/add-hyperdrive-support branch from b1e7d8a to 75cde6a Compare November 1, 2023 20:28

Skye-31 reviewed Nov 2, 2023

View reviewed changes

tmthecoder added 4 commits November 2, 2023 09:18

Add Hyperdrive binding support in wrangler dev

8767191

remove hyperdrive local dev warning

2aac644

Add changeset

b129184

Add e2e tests for Hyperdrive

eb60fde

tmthecoder force-pushed the tejas/add-hyperdrive-support branch from 75cde6a to eb60fde Compare November 2, 2023 14:19

tmthecoder requested review from Skye-31 and penalosa November 2, 2023 16:39

empty commit to kick off builds

7d5f3f4

Skye-31 merged commit f867e01 into cloudflare:main Nov 7, 2023

workers-devprod mentioned this pull request Nov 7, 2023

Version Packages #4291

Merged

tmthecoder deleted the tejas/add-hyperdrive-support branch November 7, 2023 18:19

gp27 mentioned this pull request Jan 8, 2024

🚀 Feature Request: #4578

Closed

Conversation

tmthecoder commented Oct 18, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

changeset-bot bot commented Oct 18, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦋 Changeset detected

Uh oh!

penalosa left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

codecov bot commented Oct 26, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

github-actions bot commented Oct 26, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

tmthecoder commented Oct 27, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

penalosa Oct 27, 2023

Choose a reason for hiding this comment

Uh oh!

penalosa Oct 27, 2023

Choose a reason for hiding this comment

Uh oh!

tmthecoder Oct 27, 2023

Choose a reason for hiding this comment

Uh oh!

penalosa left a comment

Choose a reason for hiding this comment

Uh oh!

tmthecoder commented Nov 1, 2023

Uh oh!

Skye-31 Nov 2, 2023

Choose a reason for hiding this comment

Uh oh!

tmthecoder Nov 2, 2023

Choose a reason for hiding this comment

Uh oh!

tmthecoder commented Nov 6, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

tmthecoder commented Oct 18, 2023 •

edited

Loading

changeset-bot bot commented Oct 18, 2023 •

edited

Loading

codecov bot commented Oct 26, 2023 •

edited

Loading

github-actions bot commented Oct 26, 2023 •

edited

Loading

tmthecoder commented Oct 27, 2023 •

edited

Loading