Skip to content

fix: use a valid compatibility date for worker templates#4279

Merged
dario-piotrowicz merged 3 commits intocloudflare:mainfrom
dnasdw:dnasdw-fix-template
Oct 27, 2023
Merged

fix: use a valid compatibility date for worker templates#4279
dario-piotrowicz merged 3 commits intocloudflare:mainfrom
dnasdw:dnasdw-fix-template

Conversation

@dnasdw
Copy link
Contributor

@dnasdw dnasdw commented Oct 25, 2023

No description provided.

@dnasdw dnasdw requested a review from a team October 25, 2023 07:25
@changeset-bot
Copy link

changeset-bot bot commented Oct 25, 2023

🦋 Changeset detected

Latest commit: ba34046

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
create-cloudflare Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Oct 25, 2023

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/6672041120/npm-package-wrangler-4279

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/6672041120/npm-package-wrangler-4279

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/6672041120/npm-package-wrangler-4279 dev path/to/script.js
Additional artifacts:
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/6672041120/npm-package-cloudflare-pages-shared-4279

Note that these links will no longer work once the GitHub Actions artifact expires.


wrangler@3.15.0 includes the following runtime dependencies:

Package Constraint Resolved
miniflare 3.20231025.0 3.20231025.0
workerd 1.20231025.0 1.20231025.0
workerd --version 1.20231025.0 2023-10-25

|

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

@codecov
Copy link

codecov bot commented Oct 25, 2023

Codecov Report

Merging #4279 (ba34046) into main (6f97326) will increase coverage by 0.16%.
Report is 15 commits behind head on main.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4279      +/-   ##
==========================================
+ Coverage   75.26%   75.43%   +0.16%     
==========================================
  Files         223      223              
  Lines       12291    12327      +36     
  Branches     3179     3187       +8     
==========================================
+ Hits         9251     9299      +48     
+ Misses       3040     3028      -12     

see 21 files with indirect coverage changes

@admah admah added the c3 Relating to C3 (create-cloudflare) package label Oct 25, 2023
Copy link
Member

@dario-piotrowicz dario-piotrowicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! thanks a bunch @dnasdw 🙂

One last small thing, could you please create a patch changeset for this? (simply by running npx changeset in the repo's root directory)

@dario-piotrowicz dario-piotrowicz merged commit 2526794 into cloudflare:main Oct 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c3 Relating to C3 (create-cloudflare) package

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants