Change default ip for dev server from 0.0.0.0 to *

[jspspike]

This provides support for ipv6 with wrangler dev

Fixes #3732

Author has addressed the following:

• Tests
  • Included
  • Not necessary because:
• Changeset (Changeset guidelines)
  • Included
  • Not necessary because:
• Associated docs
  • Issue(s)/PR(s):
  • Not necessary because:

Note for PR author:

We want to celebrate and highlight awesome PR review! If you think this PR received a particularly high-caliber review, please assign it the label highlight pr review so future reviewers can take inspiration and learn from it.

[changeset-bot]

🦋 Changeset detected

Latest commit: aa53ab4

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages

Name	Type
wrangler	Patch
miniflare	Patch
@cloudflare/pages-shared	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[codecov]

Codecov Report

Merging #4307 (aa53ab4) into main (3cf120c) will increase coverage by 0.18%.
Report is 2 commits behind head on main.
The diff coverage is 23.52%.

@@            Coverage Diff             @@
##             main    cloudflare/workers-sdk#4307      +/-   ##
==========================================
+ Coverage   75.28%   75.46%   +0.18%     
==========================================
  Files         223      225       +2     
  Lines       12357    12449      +92     
  Branches     3198     3227      +29     
==========================================
+ Hits         9303     9395      +92     
  Misses       3054     3054              

Files	Coverage Δ
packages/wrangler/src/config/validation.ts	90.09% <100.00%> (ø)
packages/wrangler/src/dev/remote.tsx	8.24% <ø> (ø)
packages/wrangler/src/https-options.ts	100.00% <100.00%> (ø)
packages/wrangler/src/dev/proxy.ts	4.51% <7.14%> (-0.07%)	⬇️

... and 6 files with indirect coverage changes

[github-actions]

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/6814508044/npm-package-wrangler-4307

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/6814508044/npm-package-wrangler-4307

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/6814508044/npm-package-wrangler-4307 dev path/to/script.js

Additional artifacts:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/6814508044/npm-package-miniflare-4307

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/6814508044/npm-package-cloudflare-pages-shared-4307

Note that these links will no longer work once the GitHub Actions artifact expires.

---

wrangler@3.15.0 includes the following runtime dependencies:

Package	Constraint	Resolved
miniflare	workspace:*	3.20231025.1
workerd	1.20231030.0	1.20231030.0
workerd --version	1.20231030.0	2023-10-30

|

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

[Cherry]

Testing this, I get the following output on my windows system now:

(don't mind the error, that's cloudflare/workerd#1408)

[mf:inf] Ready on http://*:8787
[mf:inf] - http://[2606:4700:110:8da6:bb53:5d3e:ac67:334e]:8787
[mf:inf] - http://[fe80::ea19:d284:e881:ca23]:8787
[mf:inf] - http://192.168.50.240:8787
[mf:inf] - http://[::1]:8787
[mf:inf] - http://127.0.0.1:8787
[mf:inf] - http://[fe80::c991:30fc:6720:d91e]:8787
[mf:inf] - http://172.24.144.1:8787

That's a lot of visual output - is there perhaps a better way to present this if there's going to be that many bind addresses to print moving forward?

[jspspike]

@Cherry This was discussed with the team previously when adding similar functionality to miniflare. We decided that showing all of them once initially would be helpful but if reviewers feel differently now we can discuss

[jspspike]

@Cherry After discussing with the team we thought it would be best to remove the ipv6 addresses from the printout

That will require a change in miniflare so this PR is blocked until that is released

[petebacondarwin]

Does :: always work? Can a user configure their computer to prevent IPV6?

[jspspike]

I'm not 100% sure, looks like you can disable ipv6 on a computer so I'll test manually and see what happens

[jspspike]

After testing with

sysctl -w net.ipv6.conf.all.disable_ipv6=1
sysctl -w net.ipv6.conf.default.disable_ipv6=1

on linux it seems to still be able to listen on ipv4 addresses

[petebacondarwin]

LGTM assuming that listening on :: always works on all machines.