Skip to content

[miniflare] fix: add miniflare bin entry#4428

Merged
mrbbot merged 1 commit intomainfrom
bcoll/miniflare-missing-bin
Nov 10, 2023
Merged

[miniflare] fix: add miniflare bin entry#4428
mrbbot merged 1 commit intomainfrom
bcoll/miniflare-missing-bin

Conversation

@mrbbot
Copy link
Contributor

@mrbbot mrbbot commented Nov 10, 2023

Fixes #4355

What this PR solves / how to test:

Miniflare 3 doesn't include a CLI anymore, but should log a useful error stating this when running npx miniflare. We had a script for this, but it wasn't correctly hooked up. 🤦 To test this, run npx miniflare in the packages/wrangler directory.

Author has addressed the following:

  • Tests
    • Included
    • Not necessary because: small change to add a bin entry tominiflare's package.json
  • Changeset (Changeset guidelines)
    • Included
    • Not necessary because:
  • Associated docs
    • Issue(s)/PR(s):
    • Not necessary because: already have migration docs suggesting users use npx wrangler dev

Note for PR author:

We want to celebrate and highlight awesome PR review! If you think this PR received a particularly high-caliber review, please assign it the label highlight pr review so future reviewers can take inspiration and learn from it.

Miniflare 3 doesn't include a CLI anymore, but should log a useful
error stating this when running `npx miniflare`. We had a script for
this, but it wasn't correctly hooked up. 🤦
@mrbbot mrbbot requested a review from a team as a code owner November 10, 2023 22:12
@changeset-bot
Copy link

changeset-bot bot commented Nov 10, 2023

🦋 Changeset detected

Latest commit: d5faff6

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
miniflare Patch
@cloudflare/pages-shared Patch
wrangler Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/6830099406/npm-package-wrangler-4428

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/6830099406/npm-package-wrangler-4428

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/6830099406/npm-package-wrangler-4428 dev path/to/script.js
Additional artifacts:
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/6830099406/npm-package-miniflare-4428
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/6830099406/npm-package-cloudflare-pages-shared-4428

Note that these links will no longer work once the GitHub Actions artifact expires.


wrangler@3.15.0 includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20231025.1
workerd 1.20231030.0 1.20231030.0
workerd --version 1.20231030.0 2023-10-30

|

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

@codecov
Copy link

codecov bot commented Nov 10, 2023

Codecov Report

Merging #4428 (d5faff6) into main (9bc52cf) will decrease coverage by 0.01%.
Report is 1 commits behind head on main.
The diff coverage is 23.52%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4428      +/-   ##
==========================================
- Coverage   75.47%   75.46%   -0.01%     
==========================================
  Files         225      225              
  Lines       12451    12449       -2     
  Branches     3229     3227       -2     
==========================================
- Hits         9397     9395       -2     
  Misses       3054     3054              
Files Coverage Δ
packages/wrangler/src/config/validation.ts 90.09% <100.00%> (ø)
packages/wrangler/src/dev/remote.tsx 8.24% <ø> (ø)
packages/wrangler/src/https-options.ts 100.00% <100.00%> (ø)
packages/wrangler/src/dev/proxy.ts 4.51% <7.14%> (-0.07%) ⬇️

... and 3 files with indirect coverage changes

@mrbbot mrbbot merged commit 3637d97 into main Nov 10, 2023
@mrbbot mrbbot deleted the bcoll/miniflare-missing-bin branch November 10, 2023 23:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Miniflare] Error: could not determine executable to run

2 participants