Skip to content

fix: output version preview alias URL and id #385

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sidvishnoi wants to merge 5 commits into
base: main
Choose a base branch
from
Open

fix: output version preview alias URL and id #385

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
5291995
fix: make version preview alias URL available in outputs
sidvishnoi Aug 29, 2025
86881c2
fix: output `version-id` for version upload
sidvishnoi Sep 11, 2025
6c47642
add missing changesets
dario-piotrowicz Mar 9, 2026
904f77c
fix formatting
dario-piotrowicz Mar 9, 2026
cbed92a
add version-id and deployment-alias-url to action.yaml
sidvishnoi Mar 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/commandOutputParsing.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,6 +112,7 @@ function handleVersionsUploadOutputEntry(
versionsOutputEntry: OutputEntryVersionUpload,
) {
setOutput("deployment-url", versionsOutputEntry.preview_url);
setOutput("deployment-alias-url", versionsOutputEntry.preview_alias_url);
Comment thread
dario-piotrowicz marked this conversation as resolved.
}

/**
Expand Down
3 changes: 2 additions & 1 deletion src/wranglerArtifactManager.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,7 +141,7 @@ describe("wranglerArtifactsManager", () => {
testOutputDir: {
"wrangler-output-2024-10-17_18-48-40_463-2e6e83.json": `
{"version": 1, "type":"wrangler-session", "wrangler_version":"3.81.0", "command_line_args":["what's up"], "log_file_path": "/here"}
{"version": 1, "type":"version-upload", "preview_url": "https://example.com"}`,
{"version": 1, "type":"version-upload", "preview_url": "https://example.com", "preview_alias_url":"https://example.alias"}`,
"not-wrangler-output.json": "test",
},
});
Expand All @@ -155,6 +155,7 @@ describe("wranglerArtifactsManager", () => {
version: 1,
type: "version-upload",
preview_url: "https://example.com",
preview_alias_url: "https://example.alias",
});
}),
it("Skips artifact entries that are not parseable", async () => {
Expand Down
1 change: 1 addition & 0 deletions src/wranglerArtifactManager.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,7 @@ const OutputEntryVersionUpload = OutputEntryBase.merge(
type: z.literal("version-upload"),
/** The preview URL associated with this version upload */
preview_url: z.string().optional(),
preview_alias_url: z.string().optional(),
}),
);

Expand Down