Merged
Conversation
Mrizwanshaik
force-pushed
the
update-ci-base-image
branch
3 times, most recently
from
08aebab to
8be72ef
Compare
Mrizwanshaik
force-pushed
the
update-ci-base-image
branch
from
81e8117 to
7fbdff3
Compare
peanball
reviewed
May 4, 2023
Contributor
peanball
left a comment
peanball
left a comment
There was a problem hiding this comment.
Some questions that need clarification.
feat(haproxy): change base image tag in pipeline config Revert "feat(haproxy): change base image tag in pipeline config -> latest" This reverts commit 0a56732.
feat(haproxy): update ci base image tag to use main (docker-cpi:main) fix(haproxy): ruby version to use latest bundle packages
address review comments
Mrizwanshaik
force-pushed
the
update-ci-base-image
branch
from
ddff414 to
38d2720
Compare
peanball
approved these changes
May 4, 2023
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
.ruby-versionand added ruby~>3.2version to gemfile