Skip to content

docs(testing): Fixed example for HelloControllerTest#143

Merged
clue merged 1 commit intoclue:mainfrom
zf2timo:patch-1
Apr 14, 2022
Merged

docs(testing): Fixed example for HelloControllerTest#143
clue merged 1 commit intoclue:mainfrom
zf2timo:patch-1

Conversation

@zf2timo
Copy link
Copy Markdown
Contributor

@zf2timo zf2timo commented Apr 12, 2022

The ServerRequest requires the HTTP Method as first parameter. This was missing in the examples.

The ServerRequest requires the HTTP Method as first parameter. This was missing in the examples.
Copy link
Copy Markdown
Contributor

@SimonFrings SimonFrings left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

This PR builds on top of #142.

Copy link
Copy Markdown
Owner

@clue clue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zf2timo Thanks for looking into this, keep it coming! :shipit:

@clue clue added the documentation Improvements or additions to documentation label Apr 14, 2022
@clue clue merged commit 2268919 into clue:main Apr 14, 2022
@zf2timo zf2timo deleted the patch-1 branch April 14, 2022 08:22
@SimonFrings SimonFrings added this to the v0.9.0 milestone Mar 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants