Remove problematic handlers#293
Open
Velite12 wants to merge 2 commits into
Open
Conversation
Remove handlers that are causing issue when taking a group quest that has relays, like Ring of Blood quests
Contributor
Author
|
Actually need to investigate a bit more |
Handle situations where bot accepts quest but we should not query requester in order to avoid double dbscript call, as this is how the core handles it for players. I also brought the original handlers back.
Contributor
Author
|
Here, the new commit I issued better fixes the issues by preserving original behavior but addressing the problem with quests that have dbscripts or are party accept flagged quests. Mainly we just check if the quest has party accept flag and if so, we don't use requester as that would be the player. We don't want the player to act like questgiver and trigger dbscripts. We also add a check in AcceptQuest which was missing, if the bot can even add the quest to their log to begin with |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove handlers that are causing issue when taking a group quest that has dbscripts, like the Ring of Blood quests. I don't think these are even necessary as, at least in my group, the bots can still take and complete quests.
These handlers are the source of a bug where if the bot takes a quest (either if you press accept or they do, and then you accept later in the case of a group quest "is starting quest" message), the player will act like the questgiver and this causes problems like spawning double of the required creatures for quest.