Skip to content

Create governance remediation process#1417

Merged
angellk merged 8 commits intocncf:mainfrom
xmulligan:patch-3
Oct 4, 2024
Merged

Create governance remediation process#1417
angellk merged 8 commits intocncf:mainfrom
xmulligan:patch-3

Conversation

@xmulligan
Copy link
Contributor

fixes: #999

fixes: cncf#999 

Signed-off-by: Bill Mulligan <billmulligan516@gmail.com>
Copy link
Member

@leonardpahlke leonardpahlke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reads well. Maybe it can be broken down lightly more (?) (i hope i dont make things up here)

  1. Anyone that identifies missing or not executed governance should open an issue or smth
  2. There are governance reviews happening that check this too
  3. If there is conflict about govnernance we align by best pratices that are defined here
  4. If a conflict about governance definition cannot be resolved TAG Contrib Strat moderates, if that doesnt help one of the TOC members and lastly the CoCC.

The first part (H2 sections) of this document reads like an enhancement proposal, the second part brings the process.

Copy link
Contributor

@lizrice lizrice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm happy with the general idea of there being a remediation process to help projects get themselves out of a situation where their governance is lacking, but as commented, I strongly oppose a change to the principle that projects are self-governing. There is a very big difference between "project asks for or is offered help from the TOC / TAG to fix issues with its governance" and "there are circumstances under which the TOC can mandate changes to the project's governance".

I'm also concerned about malicious / competitor actors using this process to stir up problems within otherwise well-functioning projects. A couple of practical ideas:

  • When raising a governance remediation issue in the TOC repo, it should be required to link to an existing issue in the project repo, and it should be clear that attempts to resolve the issue internally have failed, over a reasonable timeframe
  • The onus should be on the reporter to show that they have done work to suggest a plausible resolution - they should be able to demonstrate that they or others have attempted to chop the wood and carry the water themselves, rather than just creating work for the maintainers

Copy link
Member

@mrbobbytables mrbobbytables left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for putting this together
I left a few comments, but in general I would lean towards focusing on what was called out as in scope for the original issue and simplify alot of the wording. IMO the important thing is there is full transparency around the remediation plan and time for others to comment.

xmulligan and others added 2 commits September 12, 2024 12:11
Co-authored-by: Liz Rice <liz@lizrice.com>
Signed-off-by: Bill Mulligan <billmulligan516@gmail.com>
Co-authored-by: Liz Rice <liz@lizrice.com>
Signed-off-by: Bill Mulligan <billmulligan516@gmail.com>
Signed-off-by: Bill Mulligan <billmulligan516@gmail.com>
Signed-off-by: Bill Mulligan <billmulligan516@gmail.com>
I've simplified the wording to make it clear that the TOC can't override and the projects are responsible for their own governance.

Signed-off-by: Bill Mulligan <billmulligan516@gmail.com>
@xmulligan
Copy link
Contributor Author

Thanks for all of the comments and discussions. Finally had a chance to catch up on this after vacation. Check the individual commits for the exact changes, but overall I've tried to simplify the wording and make it clear that projects are responsible for their own governance, but can get help from the TOC.

@BenTheElder
Copy link

Thanks! I agree this is much clearer now 🙏

Copy link
Contributor

@TheFoxAtWork TheFoxAtWork left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This revision is much clearer, thank you for incorporating the community comments!

Signed-off-by: Bill Mulligan <billmulligan516@gmail.com>
Copy link
Contributor

@TheFoxAtWork TheFoxAtWork left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for getting this written up and incorporating all comments. TOC members - please review!

@angellk angellk requested review from angellk and removed request for jberkus and leonardpahlke September 26, 2024 22:39
Copy link
Member

@mrbobbytables mrbobbytables left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @xmulligan this looks much better :)

LGTM with one nit before merge: the TOC private email is incorrect^^;;;

Co-authored-by: Bob Killen <killen.bob@gmail.com>
Signed-off-by: Bill Mulligan <billmulligan516@gmail.com>
@xmulligan
Copy link
Contributor Author

Thanks, just fixed!

Copy link
Member

@mrbobbytables mrbobbytables left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks!

@angellk angellk added the kind/docs Docs related changes or updates label Oct 4, 2024
Copy link
Contributor

@angellk angellk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @xmulligan - all the changes look great. lgtm

@angellk angellk merged commit b1d1fe3 into cncf:main Oct 4, 2024
@xmulligan xmulligan deleted the patch-3 branch October 4, 2024 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/docs Docs related changes or updates

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Governance Remediation Process

9 participants