Skip to content

What: Formalize Domain Technical Review (DTR) process#1441

Merged
TheFoxAtWork merged 18 commits intocncf:mainfrom
angellk:angellk-dtr-1
Oct 8, 2024
Merged

What: Formalize Domain Technical Review (DTR) process#1441
TheFoxAtWork merged 18 commits intocncf:mainfrom
angellk:angellk-dtr-1

Conversation

@angellk
Copy link
Contributor

@angellk angellk commented Sep 24, 2024 •
edited
Loading

Why:

  • Enable projects to apply to CNCF and move levels more quickly by providing a framework for TAGs and community members to get engaged in technical reviews
  • Ensure consistency in domain technical reviews
  • Provide a standard format that can live with the projects as they move levels within the CNCF

This change addresses the need by:

  • Establishing domain technical reviews process in the TAG/resources folder per the scope of the DTR WG
  • Incorporating the General Technical Review questions in a questionnaire the projects can use as the basis of project presentations, or in lieu of a presentation to a TAG
  • Providing a standard template for domain technical reviews that TAG leads or community domain experts can use to review and provide recommendations to the TOC

cc: @cncf/cncf-toc @cncf/cncf-end-users

HackMD and others added 16 commits September 18, 2024 13:15
added GTR to the incubation application
bcc0301 
Filling out the General Technical Review questions may be done instead of presenting to a TAG and can also satisfy few several engineering principle requirements.
General Technical Review questions v1.0
cdfe236 
General Technical Review questions to be used in conjunction with Sandbox, Incubation, Graduation applications.
update graduation template with General Technical Review questions
b2328c1 
General Technical Review questions may be used in lieu of project presentation and/or several of the engineering principles requirements.
last changed at Sep 18, 2024 4:03 PM, pushed by Karena Angell
a060e7c
last changed at Sep 18, 2024 4:03 PM, pushed by Karena Angell
fff51e2
@angellk
Merge branch 'cncf:main' into angellk-dtr-1
03e4320
Create TAG Domain Technical Review template
d54e870
last changed at Sep 22, 2024 7:24 PM, pushed by Karena Angell
00e8af1
update with links to DTR templates and info
9077298
updated with DTR
454dc44
clarifications from mrbobbytables
a727836
last changed at Sep 22, 2024 7:25 PM, pushed by Karena Angell
f2a874d
Incorporated DTR further in README
2fb90db
set version v1.0
0905041
set version 1.0
6c93b52
incorporated @mrbobbytables input
11e4604
@angellk angellk added the kind/docs Docs related changes or updates label Sep 24, 2024
TheFoxAtWork
TheFoxAtWork requested changes Sep 24, 2024
View reviewed changes
@TheFoxAtWork
Copy link
Contributor

TheFoxAtWork commented Sep 24, 2024

Some suggested changes, overall happy to see this moving forward. I hope it supports more meaningful project discussions and engagement between TAGs and projects while also elevating the design thinking projects engage in to adopters and TOC members.

@angellk @TheFoxAtWork
Apply suggestions from @TheFoxAtWork
bacaf71 
Co-authored-by: Emily Fox <33327273+TheFoxAtWork@users.noreply.github.com>
Signed-off-by: Karena Angell <kangell@redhat.com>
xmulligan
xmulligan reviewed Sep 26, 2024
View reviewed changes
xmulligan
xmulligan reviewed Sep 26, 2024
View reviewed changes
xmulligan
xmulligan reviewed Sep 26, 2024
View reviewed changes
xmulligan
xmulligan reviewed Sep 26, 2024
View reviewed changes
@angellk @xmulligan
Apply suggestions from @xmulligan
bd24d8c 
Co-authored-by: Bill Mulligan <billmulligan516@gmail.com>
Signed-off-by: Karena Angell <kangell@redhat.com>
@mrbobbytables mrbobbytables mentioned this pull request Oct 1, 2024
Closed
dims
dims approved these changes Oct 4, 2024
View reviewed changes
Copy link
Member

@dims dims left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@angellk angellk requested a review from TheFoxAtWork October 4, 2024 13:30
@angellk
Copy link
Contributor Author

angellk commented Oct 6, 2024

Thank you to everyone who contributed to the DTR process! This was a great collaboration across the various TAGs and technical domains. Please submit any additional reviews or comments prior to Friday, October 11, 2024. This PR will be merged at that time to align with the moving levels freeze prior to KubeCon.

nikhita
nikhita approved these changes Oct 7, 2024
View reviewed changes
Copy link
Member

@nikhita nikhita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for all the heavy lifting here!

@TheFoxAtWork
Copy link
Contributor

TheFoxAtWork commented Oct 8, 2024

We have 3 TOC reviewers and all major comments have been resolved over 1 week. IAW our TOC decision process:

After resolving all review comments, the PR must remain open for a reasonable time to allow for any additional comments.
This PR is being merged.

@TheFoxAtWork TheFoxAtWork merged commit 58e96d0 into cncf:main Oct 8, 2024
@angellk angellk mentioned this pull request Oct 9, 2024
Closed
@angellk angellk mentioned this pull request Nov 2, 2024
Closed
@angellk angellk deleted the angellk-dtr-1 branch November 8, 2025 23:36
@RainbowMango RainbowMango mentioned this pull request Jan 27, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TheFoxAtWork TheFoxAtWork TheFoxAtWork approved these changes

@dims dims dims approved these changes

+2 more reviewers

@xmulligan xmulligan xmulligan left review comments

@nikhita nikhita nikhita approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

kind/docs Docs related changes or updates

Projects

CNCF TOC Board
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@angellk @TheFoxAtWork @dims @nikhita @xmulligan