Skip to content

systemd: dynamic overview health card via manifest#23127

Open
pfeifferj wants to merge 1 commit into
cockpit-project:mainfrom
pfeifferj:feat/systemd-overview-health-dynamic
Open

systemd: dynamic overview health card via manifest#23127
pfeifferj wants to merge 1 commit into
cockpit-project:mainfrom
pfeifferj:feat/systemd-overview-health-dynamic

Conversation

@pfeifferj
Copy link
Copy Markdown

the hardcoded allowlist in PageStatusNotifications is replaced with iteration over a new top-level "overview-health" manifest field. each package opts in explicitly, letting any plugin contribute entries without changes to the systemd package.

The hardcoded allowlist in PageStatusNotifications is replaced with
iteration over a new top-level "overview-health" manifest field.
Each package opts in explicitly, letting any plugin contribute
entries without changes to the systemd package.

Signed-off-by: Josephine Pfeiffer <hi@josie.lol>
@pfeifferj
Copy link
Copy Markdown
Author

/packit retest-failed

Comment thread pkg/shell/manifests.ts
preload: string[] | undefined;
"overview-health": string[] | undefined;
parent: ManifestParentSection | undefined;
".checksum": string | undefined;
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this changes how manifest works we'll need to discuss this. My initial thought is that we should have something more generic than this, will raise with the team next week

@allisonkarlitskaya
Copy link
Copy Markdown
Member

I think @mvollmer might be a better reviewer here...

@Venefilyn
Copy link
Copy Markdown
Member

We didn't have time to discuss this in our tech discussion meeting yet. But as I mentioned before, personally feels like we can do something more generic here if we decided to make it flexible

Maybe { dynamic_page: { <page-name>: {<data-structure decided by page>} } }? That way we overview health card can look for manifest[“overview”][“status”]
E.g. any page could then add this to their manifest:

{
  "dynamic_page": {
    "overview":  {
      "status": ["system/services", "updates"]
    }
  }
}

But as we touch the manifest so rarely we don't want to make changes to it if we can avoid it. Hence why I suggest we wait for the meeting (next one will be May 6th)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants