systemd: dynamic overview health card via manifest#23127
Conversation
The hardcoded allowlist in PageStatusNotifications is replaced with iteration over a new top-level "overview-health" manifest field. Each package opts in explicitly, letting any plugin contribute entries without changes to the systemd package. Signed-off-by: Josephine Pfeiffer <hi@josie.lol>
|
/packit retest-failed |
| preload: string[] | undefined; | ||
| "overview-health": string[] | undefined; | ||
| parent: ManifestParentSection | undefined; | ||
| ".checksum": string | undefined; |
There was a problem hiding this comment.
Since this changes how manifest works we'll need to discuss this. My initial thought is that we should have something more generic than this, will raise with the team next week
|
I think @mvollmer might be a better reviewer here... |
|
We didn't have time to discuss this in our tech discussion meeting yet. But as I mentioned before, personally feels like we can do something more generic here if we decided to make it flexible Maybe {
"dynamic_page": {
"overview": {
"status": ["system/services", "updates"]
}
}
}But as we touch the manifest so rarely we don't want to make changes to it if we can avoid it. Hence why I suggest we wait for the meeting (next one will be May 6th) |
the hardcoded allowlist in
PageStatusNotificationsis replaced with iteration over a new top-level "overview-health" manifest field. each package opts in explicitly, letting any plugin contribute entries without changes to the systemd package.