Merged
Conversation
Codacy's Analysis Summary0 new issue (≤ 1 medium issue) Review Pull Request in Codacy →
|
jorgebraz
reviewed
Jan 15, 2026
Contributor
jorgebraz
left a comment
jorgebraz
left a comment
There was a problem hiding this comment.
Does this change impact existing SH customers in any way?
For example: will customers have to change anything in their installations so logging works for them?
Contributor
Author
Nope, this change only affects customers that are doing a fresh (and first) install of the SH instance. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The chart version was causing some issues as well as the config file that we were using for said release. The result of this change is the logs being displayed in Grafana (example was obtained by port-forwarding the grafana service and checking the datasource for loki)