Skip to content

changed rtl behaviour#3

Merged
AlemTuzlak merged 1 commit intocode-forge-io:mainfrom
AhmedNawaf:rtl-effect
Jul 17, 2023
Merged

changed rtl behaviour#3
AlemTuzlak merged 1 commit intocode-forge-io:mainfrom
AhmedNawaf:rtl-effect

Conversation

@AhmedNawaf
Copy link
Copy Markdown
Contributor

Description

I just tried this tool on my project (which has an RTL direction btw).
The layout is affected by setting the direction to "rtl" in the html tag.
The direction is shifted to the right which makes it a bad layout in rtl remix apps.

Fixes # (issue)

I added a CSS property to remain the same direction even if dir="rtl" exists.
It shouldn't affect any functionality.
Forgive my prettier formatter, It changed every double quotation mark to the single one :)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Unit tests

Checklist:

  • My code follows the guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings or errors
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@AlemTuzlak
Copy link
Copy Markdown
Contributor

@Sa23sa Thank you for your contribution, from looking at the code this doesn't fix the actual issue of rtl but forces the devtools to be oriented a certain way. I am wondering would you prefer that the layout shifts from ltr to rtl when the flag is present or if it was hardcoded like this? I would like to hear your thoughts on how you would like this handled and if you would want it changing directions

@AhmedNawaf
Copy link
Copy Markdown
Contributor Author

@AlemTuzlak The issue is that devtools layout is affected if your remix app is in RTL direction.
It forces the devtools to shift everything to the right and that's not what we want.
Here's a screenshot of the devtools if dir="rtl" in html tag is specified:

rtl-direction

What is preferred is whether your remix app is in RTL direction or not, the devtools direction should stay the same.
Here's a screenshot after adding the property in RTL remix app.

ltr-direction

@AlemTuzlak AlemTuzlak merged commit 89a3798 into code-forge-io:main Jul 17, 2023
@AlemTuzlak
Copy link
Copy Markdown
Contributor

@Sa23sa Thank you for this one! I merged it and released v1.0.6 with rtl support!

@AhmedNawaf AhmedNawaf deleted the rtl-effect branch July 26, 2023 06:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants