fix tempfile usage in python tests on windows#50
Merged
matt-codecov merged 1 commit intomainfrom Sep 24, 2024
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #50 +/- ##
=======================================
Coverage 98.53% 98.53%
=======================================
Files 22 22
Lines 6776 6776
=======================================
Hits 6677 6677
Misses 99 99
☔ View full report in Codecov by Sentry. |
Swatinem
approved these changes
Sep 20, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://github.com/codecov/codecov-rs/actions/runs/10949397825/job/30403888643 when building wheels for release, pytest fails on windows because of quirks with windows tempfiles
confirming the fix was kind of a pain but now i have a windows dev environment set up in a VM