Profile Pic Upload Routes#528
Merged
maxaaronson merged 9 commits intocodeforboston:mainfrom Mar 24, 2026
Merged
Conversation
DMalone87
requested changes
Mar 22, 2026
backend/routes/users.py
Outdated
| key, | ||
| ExtraArgs={ | ||
| "ContentType": file.mimetype, | ||
| "ACL": "private", |
Collaborator
There was a problem hiding this comment.
This line actually needs to be removed. ACLs are likely disabled by the object ownership settings. The statement should just be:
s3.upload_fileobj(
file,
bucket,
key,
ExtraArgs={
"ContentType": file.mimetype,
},
)
backend/routes/users.py
Outdated
| return jsonify({"error": "Empty file"}), 400 | ||
|
|
||
| # Fetch user | ||
| uid = get_jwt_identity() |
Collaborator
There was a problem hiding this comment.
Looks like you fetch the user twice here. You already got this value on line 152.
DMalone87
approved these changes
Mar 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.