Repository navigation
Conversation
Avoid executing PCRE for static routes by checking for PCRE metacharacters (including pattern delimiter '#') using strpbrk(). If none are present, perform a direct string comparison against the request URI. This reduces matching overhead from O(N) PCRE invocations to O(1) string checks for static routes while strictly preserving registration precedence and existing handler, Closure, redirect, and locale behavior.
ddevsr
approved these changes
Nov 2, 2026
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Strict equality skips previously matching routes for URIs ending in an allowed newline, potentially sending requests to a catch-all or 404; preserve regex handling for this case and add a regression test.
1 open issue
What changed in this PR
Optimizes CodeIgniter’s route matching by bypassing regular expressions for static route keys while retaining ordered route evaluation.
Changes:
- Adds direct string comparison for routes without regex metacharacters.
- Keeps shared dispatch logic for static and dynamic matches.
- Adds tests for controllers, closures, numeric keys, additional segments, and dynamic-route precedence.
Assumed target: develop, since no base branch is specified. Validation used focused code inspection; automated tests remain for CI.
| File | Description |
|---|---|
tests/system/Router/RouterTest.php |
Adds static-route matching and precedence tests. |
system/Router/Router.php |
Introduces the static-route fast path and shared dispatch flow. |
Review effort: Balanced
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Description
In
Router::checkRoutes(), every registered route was unconditionally evaluated withpreg_match('#^' . $routeKey . '$#u', $uri, $matches). In applications with dozens or hundreds of routes, matching routes located later in the table (or handling 404s) incurs significant PCRE overhead.This PR adds a fast-path for static routes:
strpbrk($routeKey, "()[]?*+{}^$\.|#")to detect PCRE metacharacters (including the pattern delimiter#).$routeKey !== $uriand skips PCRE execution.$routeKey === $uri, initializes$matches = [$uri]and proceeds directly to dispatch.Benchmark (10,000 iterations per scenario)
Checklist: