Repository navigation
Conversation
carson-codeigniter4
Bot
added
the
bug
paulbalandan
reviewed
Nov 6, 2026
Comment on lines
+369
to
+370
| $pragma = ($schema === null ? '' : $this->escapeIdentifiers($schema) . '.') | ||
| . 'foreign_key_list(' . $this->escapeIdentifiers($tableName) . ')'; |
Member
There was a problem hiding this comment.
escapeIdentifiers() returns any string containing ( unchanged because it treats it as a SQL expression. For a valid table named child(v2), this generates PRAGMA foreign_key_list(child(v2)), which fails to parse. Please quote the PRAGMA argument as a literal table name and quote any schema qualifier separately. A regression test that creates child(v2) and reads its foreign keys would cover the bypass.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
SQLite3\Connection::_foreignKeyData()interpolated$tabledirectly intoPRAGMA foreign_key_list({$table})without identifier escaping or attached database prefix handling. This caused syntax errors on table names containing hyphens, spaces, reserved SQL words, or attached schemas (e.g.schema.table). Identifiers are now escaped and schema prefixes are handled outside parentheses.Checklist: