Skip to content

Conversation

@kenjis
Copy link
Member

@kenjis kenjis commented Oct 2, 2023

Description
CI 4.4 is already released, and there are vulnerabilities in prior to 4.3.5.

  • update minimum CI4 version to 4.3.5
  • remove code for CI 4.2.x or before

Checklist:

  • Securely signed commits
  • [] Component(s) with PHPDoc blocks, only if necessary or adds value
  • [] Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

Copy link
Collaborator

@datamweb datamweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm on mobile, but I guess we need a refactor. For example below:

if (version_compare(CodeIgniter::CI_VERSION, '4.3.0', '>=')) {

@kenjis kenjis force-pushed the update-min-CI4-version-435 branch from e36e4ee to 4c381f4 Compare October 2, 2023 22:51
@kenjis kenjis changed the title chore: update minimum CI4 version to 4.3.5 refactor: update minimum CI4 version to 4.3.5 Oct 2, 2023
@kenjis kenjis added the refactor Pull requests that refactor code label Oct 2, 2023
@kenjis
Copy link
Member Author

kenjis commented Oct 2, 2023

Removed code for CI 4.2.x or before.

@kenjis kenjis mentioned this pull request Oct 3, 2023
5 tasks
Copy link
Collaborator

@datamweb datamweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Thank you!

@kenjis kenjis merged commit e3ab1ac into codeigniter4:develop Oct 3, 2023
@kenjis kenjis deleted the update-min-CI4-version-435 branch October 3, 2023 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

refactor Pull requests that refactor code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants