Skip to content

feat(debarrel): sharding#9

Merged
sahilmob merged 7 commits intomainfrom
feat/sharding
Apr 8, 2026
Merged

feat(debarrel): sharding#9
sahilmob merged 7 commits intomainfrom
feat/sharding

Conversation

@sahilmob
Copy link
Copy Markdown
Contributor

@sahilmob sahilmob commented Apr 6, 2026

  • Debarrel sharding
  • Move the skill installation step to a separate node

@sahilmob sahilmob requested a review from mohebifar April 6, 2026 20:08
@sahilmob sahilmob requested a review from mohebifar April 8, 2026 14:12
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds sharding support to the debarrel codemod workflow and separates skill installation into its own workflow node to enable running the transform in shard-based PRs.

Changes:

  • Introduces shard evaluation (by CODEOWNERS or directory) and a matrix-based PR strategy in the codemod workflow.
  • Adds getSelector to support selecting candidate files for sharded execution.
  • Adds codemodctl dependency and adjusts TypeScript config for the codemod package.

Reviewed changes

Copilot reviewed 4 out of 5 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
pnpm-lock.yaml Locks new dependencies (notably codemodctl) and updated dependency graph.
codemods/debarrel/workflow.yaml Adds shard evaluation node, matrix shard execution node that opens draft PRs, and separates skill installation into its own node.
codemods/debarrel/tsconfig.json Removes a couple of compiler options and enables skipLibCheck.
codemods/debarrel/scripts/codemod.ts Adds getSelector and updates transform signature to accept options.
codemods/debarrel/package.json Adds codemodctl as a runtime dependency.
Files not reviewed (1)
  • pnpm-lock.yaml: Language not supported

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

"noFallthroughCasesInSwitch": true,
"noUncheckedIndexedAccess": true
"noUncheckedIndexedAccess": true,
"skipLibCheck": true
Copy link

Copilot AI Apr 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Setting skipLibCheck: true weakens the check-types gate by skipping type-checking of all declaration files, which can mask real type issues introduced by dependency updates. If this was added to work around a specific library typing problem, it would be better to address that directly (or at least document why this relaxation is necessary).

Suggested change
"skipLibCheck": true
"skipLibCheck": false

Copilot uses AI. Check for mistakes.
@sahilmob sahilmob merged commit 6e71b86 into main Apr 8, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants