Update Code to 1.83.1#6488
Merged
code-asher merged 2 commits intocoder:mainfrom Oct 19, 2023
benz0li:code-1.83.1
Merged
Conversation
Contributor
Author
|
Ping @code-asher. Please review and let the checks run. Should the Safari error still occur: Please resolve. Thank you. |
Contributor
Author
|
Functionality [modified by patches] tested and found to work:
Jupyter Notebooks also work fine:
|
Member
|
I need to fix those checks so they run for repeat contributors. If Safari is still an issue I should be able to fix it this week. |
Not sure why it needs a lookbehind unless a number followed by a capital letter is not supposed to be considered a new word, which seems wrong to me. The tests do not contain any numbers so I can only guess.
code-asher
approved these changes
Oct 19, 2023
Contributor
Author
|
@code-asher I have also smoke-tested Same (positive) results as #6488 (comment). |
Member
|
Awesome, thank you. I think I will promote the release today. |
yiliang114
pushed a commit
to yiliang114/code-server
that referenced
this pull request
Jan 23, 2025
* Update Code to 1.83.1 * Patch out lookbehind for Safari support Not sure why it needs a lookbehind unless a number followed by a capital letter is not supposed to be considered a new word, which seems wrong to me. The tests do not contain any numbers so I can only guess. --------- Co-authored-by: Asher <ash@coder.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6475