🤖 fix: model settings improvements and custom model persistence #1428
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 05c1031a7c
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
ammar-agent
force-pushed
the
model-settings-zzqp
branch
12 times, most recently
from
733d9a5 to
27f51cc
Compare
Add a Model Defaults section with searchable dropdowns for: - Default Model: model used for new workspaces - Compaction Model: model used for /compact (falls back to workspace model) Show a subtle 'configure' link during compaction (when no custom model is set) that opens Settings → Models. Add story to capture the configure hint state.
ammar-agent
force-pushed
the
model-settings-zzqp
branch
from
27f51cc to
fbc8c6c
Compare
…down - Move model row tooltip trigger from entire row to dedicated Info icon - Replace custom SearchableModelSelect with cmdk-based combobox for proper keyboard navigation (arrow keys, type-to-filter, scrolling) - Restyle Model Defaults section to match table aesthetic with header row and horizontal label/dropdown layout - Restyle Add Model form with consistent header styling and backgrounds
- Add overflow-visible to PopoverContent to prevent clipping - Use flex layout with max-h on Command container - Make Command.List flex-1 with overflow-y-auto for scrolling
cmdk's scrolling behavior was unreliable. Replace with a custom implementation that: - Uses native div with overflow-y-auto for reliable scrolling - Implements arrow key navigation with highlighted index tracking - Auto-scrolls highlighted items into view - Supports type-to-filter with search input - Tracks mouse hover for highlight updates
The overflow-hidden constraint was preventing child elements from scrolling. Removed it along with max-h constraint from base styles so individual popovers can control their own overflow behavior.
- Added modal prop to Popover for proper focus trapping in dialog context - Added explicit max-h to PopoverContent as backup constraint
Add a version counter to useProvidersConfig that tracks fetch requests. When an optimistic update occurs, the counter is incremented to invalidate any in-flight fetches. This prevents race conditions where a slow initial fetch response would overwrite an optimistic update with stale data. Also adds a UI test for the custom model addition flow (though it has known limitations with Radix Dialog portals in happy-dom).
ammar-agent
force-pushed
the
model-settings-zzqp
branch
from
4890751 to
4684117
Compare
ammar-agent
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes several issues in the Settings → Models UI:
Custom model persistence bug - Adding a custom model would "flash" then disappear. Root cause:
updateModelsOptimisticallyreturned stale data because it computed the new models array inside a React state updater (async) but returned immediately. Fixed by using a synchronousconfigRefto compute and return values reliably.Model dropdown scrolling - Replaced cmdk-based implementation with custom command component for reliable scrolling behavior in model selectors.
Popover overflow - Fixed popover overflow issues preventing proper scrolling in dropdowns.
Changes
src/browser/hooks/useProvidersConfig.ts: AddedconfigReffor synchronous access to config state; prevents stale returns from optimistic update helperssrc/browser/components/ui/command.tsx: Custom command implementation replacing cmdksrc/browser/components/ui/popover.tsx: Added modal prop, fixed overflow stylestests/ui/customModels.integration.test.ts: Integration test reproducing the custom model persistence bugTesting
updateModelsOptimisticallyreturns correct data for immediate persistenceGenerated with
mux• Model:anthropic:claude-opus-4-5• Thinking:medium• Cost:$37.78