feat(block tunes): Conversion Menu in Block Tunes#2692
Merged
TatianaFomina merged 38 commits intonextfrom Apr 27, 2024
Merged
Conversation
TatianaFomina
requested review from
gohabereg,
ilyamore88 and
neSpecc
as code owners
gohabereg
reviewed
Apr 21, 2024
| public open(targetBlock: Block = this.Editor.BlockManager.currentBlock): void { | ||
| this.opened = true; | ||
|
|
||
| // console.log(this.getConvertToItems()); |
Member
There was a problem hiding this comment.
Suggested change
| // console.log(this.getConvertToItems()); |
| * | ||
| * @param currentToolName - current block tool name | ||
| */ | ||
| private getConvertToItems(currentToolName: string): TunesMenuConfigItem[] { |
Member
There was a problem hiding this comment.
Looks like the result could be cached somewhere
Contributor
Author
There was a problem hiding this comment.
Good point, fixed
neSpecc
reviewed
Apr 22, 2024
gohabereg
reviewed
Apr 24, 2024
| * | ||
| * @param currentBlock - block we are about to open block tunes for | ||
| */ | ||
| private async getConvertToItems(currentBlock: Block): Promise<PopoverItemDefaultParams[]> { |
Member
There was a problem hiding this comment.
It seems the comment about cache is relevant again now
Contributor
Author
There was a problem hiding this comment.
can not cache. "Convert to" items list is different every time. For each block there will be different subset of tools it can be converted to. It depends on current block type and data
neSpecc
reviewed
Apr 24, 2024
neSpecc
reviewed
Apr 25, 2024
neSpecc
approved these changes
Apr 26, 2024
gohabereg
approved these changes
Apr 27, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Convert tonow also available in Block Tunes!