Skip to content

Allow adding a large product #1077

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
alexabird merged 1 commit into from
Jan 27, 2026
Merged

Allow adding a large product #1077

alexabird merged 1 commit into from
Jan 27, 2026

Conversation

@e-hosea
Copy link
Contributor

@e-hosea e-hosea commented Sep 16, 2025 •
edited
Loading

This PR allows a large file upload (separate server settings might need to be updated to allow bigger files and longer time out).

@e-hosea
Copy link
Contributor Author

e-hosea commented Dec 4, 2025

@alexabird can you review this please?

ardasmax
ardasmax suggested changes Dec 4, 2025
View reviewed changes
...talog-ui-search/src/main/java/org/codice/ddf/catalog/ui/config/ConfigurationApplication.java Outdated
private String mapHome = "";

private int maximumUploadSize = 1_048_576;
private long maximumUploadSize = 1_048_576L;
Copy link

@ardasmax ardasmax Dec 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd put a comment here like the other variables you've added

Copy link
Contributor Author

@e-hosea e-hosea Dec 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

ardasmax
ardasmax approved these changes Dec 5, 2025
View reviewed changes
Copy link

@ardasmax ardasmax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Liz, looking through the aus one now

@alexabird alexabird marked this pull request as ready for review December 5, 2025 01:30
@alexabird
Copy link
Collaborator

alexabird commented Dec 5, 2025

build now

@cxddfuibot
Copy link
Collaborator

cxddfuibot commented Dec 5, 2025

Internal build has been started, your results will be available at build completion.

@alexabird alexabird mentioned this pull request Dec 5, 2025
Closed
@cxddfuibot
Copy link
Collaborator

cxddfuibot commented Dec 5, 2025

Build FAILURE See the job results in legacy Jenkins UI or in Blue Ocean UI.

@cxddfuibot
Copy link
Collaborator

cxddfuibot commented Dec 5, 2025

Suspected Failure(s):

  • Code Formatting Violations (fmt-maven-plugin)

@e-hosea
Copy link
Contributor Author

e-hosea commented Dec 7, 2025

build now

@cxddfuibot
Copy link
Collaborator

cxddfuibot commented Dec 7, 2025

Internal build has been started, your results will be available at build completion.

@cxddfuibot
Copy link
Collaborator

cxddfuibot commented Dec 8, 2025

Build SUCCESS See the job results in legacy Jenkins UI or in Blue Ocean UI.

@e-hosea
Copy link
Contributor Author

e-hosea commented Dec 12, 2025

@ardasmax @alexabird The refactoring of AutoCloseableMultipartBody/Factory into multipart-utils module is done. Can you please have a quick review in regards to that? Thanks

@e-hosea
Copy link
Contributor Author

e-hosea commented Dec 12, 2025

build now

@cxddfuibot
Copy link
Collaborator

cxddfuibot commented Dec 12, 2025

Internal build has been started, your results will be available at build completion.

@cxddfuibot
Copy link
Collaborator

cxddfuibot commented Dec 12, 2025

Build SUCCESS See the job results in legacy Jenkins UI or in Blue Ocean UI.

@e-hosea
Copy link
Contributor Author

e-hosea commented Jan 5, 2026

@ardasmax @alexabird The refactoring of AutoCloseableMultipartBody/Factory into multipart-utils module is done. Can you please have a quick review in regards to that? Thanks

@ardasmax @alexabird just checking that you're happy with the additional changes in multipart-utils module and how it's included?

regan-prendergast
regan-prendergast approved these changes Jan 20, 2026
View reviewed changes
Copy link

@regan-prendergast regan-prendergast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hero success

@e-hosea
Copy link
Contributor Author

e-hosea commented Jan 21, 2026

build now

@cxddfuibot
Copy link
Collaborator

cxddfuibot commented Jan 21, 2026

Internal build has been started, your results will be available at build completion.

@cxddfuibot
Copy link
Collaborator

cxddfuibot commented Jan 21, 2026

Build SUCCESS See the job results in legacy Jenkins UI or in Blue Ocean UI.

@alexabird alexabird merged commit 2524dbc into codice:master Jan 27, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@andrewkfiedler andrewkfiedler andrewkfiedler approved these changes

@alexabird alexabird alexabird approved these changes

@derekwilhelm derekwilhelm derekwilhelm approved these changes

+3 more reviewers

@KeanuZeHamza KeanuZeHamza KeanuZeHamza left review comments

@regan-prendergast regan-prendergast regan-prendergast approved these changes

@ardasmax ardasmax ardasmax approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@e-hosea @alexabird @cxddfuibot @andrewkfiedler @derekwilhelm @regan-prendergast @ardasmax @KeanuZeHamza