Skip to content

Online Safety Act updates#2004

Merged
ArtOfCode- merged 25 commits into
developfrom
art/online-safety-updates
Apr 1, 2026
Merged

Online Safety Act updates#2004
ArtOfCode- merged 25 commits into
developfrom
art/online-safety-updates

Conversation

@ArtOfCode-

Copy link
Copy Markdown
Member
  • Add options for complaints about process adherence or failure in statutory duty

@codecov

codecov Bot commented Mar 3, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 88.88889% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 80.90%. Comparing base (5eb67ed) to head (e3f190e).
⚠️ Report is 26 commits behind head on develop.

Files with missing lines Patch % Lines
app/controllers/complaints_controller.rb 88.88% 2 Missing ⚠️
Additional details and impacted files
Components Coverage Δ
controllers 76.21% <88.88%> (+0.10%) ⬆️
helpers 85.09% <ø> (ø)
jobs 66.88% <ø> (ø)
models 93.04% <ø> (ø)
tasks 61.11% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ArtOfCode- ArtOfCode- marked this pull request as ready for review March 22, 2026 15:46
@ArtOfCode- ArtOfCode- requested review from Oaphi and cellio March 22, 2026 15:47

@cellio cellio left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for putting this together. I reviewed by going through the training in the UI and leaving comments in the HTML source here, so order of comments in the diff is not the order I left them in (mentioning because you might see some things that came out as forward-references but weren't written that way).

A few small comments on content, and two other issues:

  • Should the network-specific parts, like your name, be behind global site settings so other deployments don't pick them up?
  • Can we log completion somewhere beyond in the DB? (I looked in the audit log.)

Comment thread app/views/complaints/training/overview.html.erb
Comment thread app/views/complaints/training/overview.html.erb
Comment thread app/views/complaints/training/definitions.html.erb Outdated
Comment thread app/views/complaints/training/definitions.html.erb
Comment thread app/views/complaints/training/handling.html.erb Outdated
Comment thread app/views/complaints/training/handling.html.erb Outdated
Comment thread app/views/complaints/training/handling.html.erb
Comment thread app/views/complaints/training/handling.html.erb
Comment thread app/views/complaints/training/conclusion.html.erb Outdated
Comment thread app/views/complaints/training/conclusion.html.erb
Comment thread app/controllers/complaints_controller.rb Outdated
Comment thread app/views/complaints/training/overview.html.erb Outdated
Comment thread app/views/layouts/osa_training.html.erb
Comment thread test/controllers/complaints_controller_test.rb Outdated
@ArtOfCode- ArtOfCode- requested review from Oaphi and cellio March 28, 2026 18:32
Comment thread app/views/complaints/training/overview.html.erb Outdated
Comment thread app/views/complaints/training/higher-risk.html.erb Outdated
Comment thread app/views/complaints/training/handling.html.erb Outdated

@cellio cellio left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much better, thanks. I ran through the training again after looking at the diff (this time in a small window to simulate a phone). The training looks good and I see the entry in the audit log now.

Thanks for adding the site settings. I left some comments about default values there.

Even with these settings, another network would need to edit some of the seeds -- references to the Codidact Foundation, our AI policy, and Discord jumped out. Let's not make the perfect the enemy of the good here; instead of trying to configure everything, we can (in a follow-on task) add some documentation to the installation guide and have this be off by default so nobody's surprised by these things in a live instance. Turning it all on in prod after deploy will not be hard for us, and others will need to do more work before they'll want to turn it on anyway.

Comment thread db/seeds/site_settings.yml Outdated
Comment thread db/seeds/site_settings.yml Outdated
Comment thread app/controllers/complaints_controller.rb
Comment thread app/views/complaints/training/handling.html.erb Outdated
Comment thread db/seeds/site_settings.yml Outdated
@ArtOfCode- ArtOfCode- requested review from Oaphi and cellio March 29, 2026 21:10

@Oaphi Oaphi left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ArtOfCode- I took the liberty to fix up the controller's tests - other than that, the changes LGTM code review-wise

@ArtOfCode- ArtOfCode- merged commit 7b6dfd1 into develop Apr 1, 2026
13 checks passed
@ArtOfCode- ArtOfCode- deleted the art/online-safety-updates branch April 1, 2026 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants