Conversation
… because List and Table widgets will make those for empty rows, but when they later are used, the widget remains a text widget which is unacceptable behavior. fixed a crash on TreeButton -- any other issues can be fixed in a similar manner.
AnyCPU
reviewed
Jan 21, 2025
kkoreilly
reviewed
Jan 26, 2025
Member
kkoreilly
left a comment
kkoreilly
left a comment
There was a problem hiding this comment.
@rcoreilly I see now that you merged this PR into #1321 already, so I will close this PR.
However, when testing this I noticed two things:
- The parts
Nonebutton will still open a dialog, which it shouldn't. - The properties map now correctly updates when switching from nil to an extant map, but it does not update when switching between two different extant maps (run the inspector in the docs and select a frame and then a text element to see this effect).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
because List and Table widgets will make those for empty rows, but when they later are used, the widget remains a text widget which is unacceptable behavior. fixed a crash on TreeButton -- any other issues can be fixed in a similar manner.