Add thread_pool_executor to constructor#536
Merged
billytrend-cohere merged 1 commit intomainfrom Jul 10, 2024
Merged
Conversation
|
Hi! I wanted to follow up on this PR as I've just submitted PR #699 which complements this implementation. This PR addressed part of issue #534 by allowing ThreadPoolExecutor configuration at the client level, which is great. However, issue #534 also mentioned the need for configurable batch_size, and some users might need per-call flexibility rather than client-wide settings. PR #699 adds:
Both PRs work together nicely - users can set a default ThreadPoolExecutor via your implementation and then override it for specific operations using the per-call parameters. Just wanted to connect these implementations since they're solving related parts of the same issue! |
fede-kamel
pushed a commit
to fede-kamel/cohere-python
that referenced
this pull request
Jan 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The PR introduces changes to the
ClientandAsyncClientclasses insrc/cohere/client.py.Summary
The changes add a
_executorattribute to both classes and set its value during initialization. TheThreadPoolExecutoris now passed as an argument during initialization, allowing for more flexibility and customization.Changes
_executorattribute is added to theClientandAsyncClientclasses.thread_pool_executorargument is added to the__init__method of both classes.self._executoris set to the providedthread_pool_executorargument._executoroutside the methods is removed.