[fix] bootstrap balances should be done only for genesis block testing#375
Merged
shrimalmadhur merged 2 commits intomasterfrom Dec 8, 2022
Merged
[fix] bootstrap balances should be done only for genesis block testing#375shrimalmadhur merged 2 commits intomasterfrom
shrimalmadhur merged 2 commits intomasterfrom
Conversation
GeekArthur
approved these changes
Dec 7, 2022
jingweicb
approved these changes
Dec 7, 2022
xiaying-peng
approved these changes
Dec 8, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes # .
Motivation
When we run parallel validation from any block other then genesis, we are using
bootstrap_balances.jsonto initialize balances which results into balance mismatch because actual balances inn-1block might have been updated and we need to use that.Solution
Add a condition to validation that, bootstrap balances only if
startIndexis empty or is genesis block.Open questions